From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbdAYOKB (ORCPT ); Wed, 25 Jan 2017 09:10:01 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33356 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbdAYOKA (ORCPT ); Wed, 25 Jan 2017 09:10:00 -0500 From: Wei Yongjun To: Greg Kroah-Hartman , Serge Semin Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc Date: Wed, 25 Jan 2017 14:09:52 +0000 Message-Id: <20170125140952.25764-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") Signed-off-by: Wei Yongjun --- drivers/misc/eeprom/idt_89hpesx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index 25d47d0..f5f2c5a 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev) pdev->ee_file->size = pdev->eesize; ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file); if (ret != 0) { - kfree(pdev->ee_file); dev_err(dev, "Failed to create EEPROM sysfs-node"); return ret; } @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev) /* Remove EEPROM sysfs file */ sysfs_remove_bin_file(&dev->kobj, pdev->ee_file); - - /* Free memory allocated for bin_attribute structure */ - kfree(pdev->ee_file); } /*