From: Jean Delvare <jdelvare@suse.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Jon Medhurst (Tixy)" <tixy@linaro.org>
Subject: Re: [PATCH] firmware: arm_scpi: Add hardware dependencies
Date: Wed, 25 Jan 2017 15:14:28 +0100 [thread overview]
Message-ID: <20170125151428.1a2a532f@endymion> (raw)
In-Reply-To: <7561802d-e9d3-2b82-35dc-465c06d6d4eb@arm.com>
On Wed, 25 Jan 2017 13:56:23 +0000, Sudeep Holla wrote:
> On 25/01/17 13:50, Jean Delvare wrote:
> > On Wed, 25 Jan 2017 13:38:47 +0000, Sudeep Holla wrote:
> >> On 25/01/17 13:32, Jean Delvare wrote:
> >>> With a name like that, I assume that the ARM SCPI protocol is only
> >>> useful on the ARM architectures.
> >>>
> >>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> >>> Fixes: 8f1498c03d15 ("firmware: arm_scpi: make it depend on MAILBOX instead of")
> >>> Cc: Sudeep Holla <sudeep.holla@arm.com>
> >>> Cc: Jon Medhurst (Tixy) <tixy@linaro.org>
> >>> ---
> >>> Please correct me if I'm wrong.
> >>
> >> I won't say you are wrong but the reason why it's named arm_scpi is
> >> because the protocol was developed by ARM. It doesnn't mean only
> >> ARM/ARM64 needs to use it, it can be used on any architecture for
> >> inter-processor communication using any communication technique
> >> (currently mailbox is the only supported in the driver)
> >
> > OK, thanks for the clarification. In practice, what other architectures
> > are using it?
>
> None, hence I didn't say you are wrong ;). I am fine having the check if
> it breaks for any other architecture with COMPILE_TEST.
Not sure what you mean here... The purpose of COMPILE_TEST is to allow
limiting the scope of a driver withing hurting the build test coverage.
> Also you have mentioned it fixes 8f1498c03d15, have you seen any
> regression with that commit ? If so, details in the commit would be
> good.
Before 8f1498c03d15, the dependency on ARM_MHU made the driver only
visible on ARM kernels. Since 8f1498c03d15, the driver is proposed to
all, which I think isn't correct. In that sense my proposed patch is
fixing a (user-friendliness) regression. But nothing serious.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-01-25 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 13:32 [PATCH] firmware: arm_scpi: Add hardware dependencies Jean Delvare
2017-01-25 13:38 ` Sudeep Holla
2017-01-25 13:50 ` Jean Delvare
2017-01-25 13:56 ` Sudeep Holla
2017-01-25 14:14 ` Jean Delvare [this message]
2017-01-25 14:20 ` Sudeep Holla
2017-01-25 15:04 ` Jean Delvare
2017-01-25 15:15 ` Sudeep Holla
2017-01-27 8:53 ` Jean Delvare
2017-01-27 9:00 ` Greg KH
2017-01-27 14:22 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125151428.1a2a532f@endymion \
--to=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox