From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdAYTuf (ORCPT ); Wed, 25 Jan 2017 14:50:35 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36452 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbdAYTud (ORCPT ); Wed, 25 Jan 2017 14:50:33 -0500 Date: Wed, 25 Jan 2017 21:50:22 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Linus Walleij , Tomasz Figa , Lee Jones , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module Message-ID: <20170125195022.yiqxnfted2vw4owh@kozik-lap> References: <1485345031-2948-1-git-send-email-m.szyprowski@samsung.com> <1485345031-2948-5-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1485345031-2948-5-git-send-email-m.szyprowski@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote: > Exynos5433 LPASS module requires some clocks for proper operation with > power domain. > > Signed-off-by: Marek Szyprowski > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 57c7bbeb65a7..16072c1c3ed3 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -1494,6 +1494,8 @@ > audio-subsystem@11400000 { > compatible = "samsung,exynos5433-lpass"; > reg = <0x11400000 0x100>, <0x11500000 0x08>; > + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; > + clock-names = "sfr0_ctrl"; You wrote that 6/7 depends on this. I prefer not to take DTS changes if the corresponding user (driver) is still under discussion because the bindings might change. I'll take it when bindings got acked or accepted. BTW, the 6/7 is a quite reasonable ABI break, but for the sake of documentation - why you did not continue with the patch for marking bidings as experimental/under-development? Best regards, Krzysztof > samsung,pmu-syscon = <&pmu_system_controller>; > #address-cells = <1>; > #size-cells = <1>; > -- > 1.9.1 >