From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752654AbdAYWl1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 17:41:27 -0500
Received: from muru.com ([72.249.23.125]:60570 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752552AbdAYWlZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 17:41:25 -0500
Date: Wed, 25 Jan 2017 14:41:16 -0800
From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        Marcel Partap <mpartap@gmx.net>, Mark Rutland <mark.rutland@arm.com>,
        Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCHv4] mfd: cpcap: Add minimal support
Message-ID: <20170125224114.GK7403@atomide.com>
References: <20170106004439.12249-1-tony@atomide.com>
 <20170124093534.GU16020@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170124093534.GU16020@dell>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Lee Jones <lee.jones@linaro.org> [170124 01:32]:
> On Thu, 05 Jan 2017, Tony Lindgren wrote:
> > +
> > +	bit = irq % cpcap->regmap_conf->val_bits;
> > +	mask = (1 << bit);
> 
> Nit: BIT()
...
> > + * Copyright (C) 2016 Tony Lindgren <tony@atomide.com>
> 
> Nit: 2017
...
> > +/*
> > + * Helpers for child devices to check the revision and vendor.
> > + *
> > + * REVISIT: No documentation for the bits below, please update
> > + * to use proper names for defines when available.
> > + */
> 
> Yes, please do that.
> 
> But you can do all of the above with subsequent patches.

OK I'll send you a BIT() follow-up patch.

> Applied, thanks.

Thanks, not seeing it in next or mfd git tree yet though, forgot
to push out?

Regards,

Tony