From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752819AbdAZHWZ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Jan 2017 02:22:25 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36333 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752326AbdAZHWY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Jan 2017 02:22:24 -0500
Date: Thu, 26 Jan 2017 08:22:19 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, tglx@linutronix.de,
        linux-usb@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v5 1/4] usb: dbc: early driver for xhci debug capability
Message-ID: <20170126072219.GB3399@gmail.com>
References: <58817A25.6080305@linux.intel.com>
 <20170122090423.GA15061@gmail.com>
 <5886DBB7.4070501@linux.intel.com>
 <20170124082039.GB8667@gmail.com>
 <5888377F.8090709@linux.intel.com>
 <20170125092355.GA24580@gmail.com>
 <20170125095736.GP6515@twins.programming.kicks-ass.net>
 <588899BA.7040108@linux.intel.com>
 <20170125143829.GS6515@twins.programming.kicks-ass.net>
 <5888C986.4020809@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5888C986.4020809@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Lu Baolu <baolu.lu@linux.intel.com> wrote:

> 
> Hi,
> 
> On 01/25/2017 10:38 PM, Peter Zijlstra wrote:
> > On Wed, Jan 25, 2017 at 08:27:38PM +0800, Lu Baolu wrote:
> >> In my driver, udelay() is mostly used to handle time out.
> >>
> >> Xdbc hides most USB things in its firmware. Early printk driver only needs
> >> to setup the registers/data structures and wait until link ready or time out.
> >> Without udelay(), I have no means to convert the polling times into waiting
> >> time.
> > What is timeout and why?
> 
> Put it in simple:
> 
> The driver sets the RUN bit in control register and polls READY
> bit in status register for the successful USB device enumeration.
> As the USB device enumeration might fail and the READY bit will
> never be set, the driver must have a timeout logic to avoid
> endless loop.

Is there any error status available in the host registers anywhere that tells us 
that enumeration did not succeed?

Thanks,

	Ingo