From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbdAZJCA (ORCPT ); Thu, 26 Jan 2017 04:02:00 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:51961 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875AbdAZJB7 (ORCPT ); Thu, 26 Jan 2017 04:01:59 -0500 Date: Thu, 26 Jan 2017 12:01:46 +0300 From: Dan Carpenter To: Greg Kroah-Hartman , Serge Semin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree() Message-ID: <20170126090145.GA942@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with kfree() is a double free. In fact, we don't need to free it at all. Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") Signed-off-by: Dan Carpenter diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index 25d47d09e1cb..f5f2c5a8d9b0 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev) pdev->ee_file->size = pdev->eesize; ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file); if (ret != 0) { - kfree(pdev->ee_file); dev_err(dev, "Failed to create EEPROM sysfs-node"); return ret; } @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev) /* Remove EEPROM sysfs file */ sysfs_remove_bin_file(&dev->kobj, pdev->ee_file); - - /* Free memory allocated for bin_attribute structure */ - kfree(pdev->ee_file); } /*