From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311AbdAZJ3R (ORCPT ); Thu, 26 Jan 2017 04:29:17 -0500 Received: from mga04.intel.com ([192.55.52.120]:40675 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbdAZJ3Q (ORCPT ); Thu, 26 Jan 2017 04:29:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,288,1477983600"; d="scan'208";a="1087477842" Date: Thu, 26 Jan 2017 11:29:11 +0200 From: Mika Westerberg To: Jean Delvare Cc: linux-gpio@vger.kernel.org, LKML , Heikki Krogerus , Linus Walleij , Mathias Nyman , Takashi Iwai , Paul Gortmaker Subject: Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate Message-ID: <20170126092911.GF17297@lahna.fi.intel.com> References: <20170125162608.58bfbfb1@endymion> <20170125161651.GX17297@lahna.fi.intel.com> <20170126100506.5edf26e3@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170126100506.5edf26e3@endymion> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 10:05:06AM +0100, Jean Delvare wrote: > Hi Mika and all, > > On Wed, 25 Jan 2017 18:16:51 +0200, Mika Westerberg wrote: > > On Wed, Jan 25, 2017 at 04:26:08PM +0100, Jean Delvare wrote: > > > The pinctrl-baytrail driver builds just fine as a module so give > > > users this option. > > > > > > Signed-off-by: Jean Delvare > > > Cc: Mika Westerberg > > > > Assuming you have checked that nothing breaks in Baytrail, I'm fine with > > this change, > > I have not, as I do not have access to any Baytrail hardware. This is > the very reason why I'd like this code to be buildable as a module: I'm > not happy with a useless 50 kB driver being loaded on all my systems. I > was hopping someone at Intel would have access to the hardware to > perform the test. We do not have all the possible hardware here. I have one Minnowboard MAX which I can test this on (like I commented in the other email) but it does not have any ACPI GPIO OpRegion stuff that is present in many Baytrail based laptops out there.