From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbdAZSz5 (ORCPT ); Thu, 26 Jan 2017 13:55:57 -0500 Received: from mail.kernel.org ([198.145.29.136]:52502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbdAZSzy (ORCPT ); Thu, 26 Jan 2017 13:55:54 -0500 Date: Thu, 26 Jan 2017 15:54:58 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan Subject: Re: [PATCH 1/3] perf ftrace: Remove needless code setting default tracer Message-ID: <20170126185458.GT10340@kernel.org> References: <1485423339-22780-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485423339-22780-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jan 26, 2017 at 06:35:37PM +0900, Taeung Song escreveu: > Lately commit a349764 made 'function_graph' be the default tracer. > So ftrace.tracer variable can't be NULL but the other code setting default > tracer remained. For this reason, remove it as below. > And use existing DEFAULT_TRACER instead of "function_graph". Rewrote a bit the commit log, applied, - Arnaldo > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Taeung Song > --- > tools/perf/builtin-ftrace.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > index d05658d..414444d 100644 > --- a/tools/perf/builtin-ftrace.c > +++ b/tools/perf/builtin-ftrace.c > @@ -202,7 +202,7 @@ int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused) > { > int ret; > struct perf_ftrace ftrace = { > - .tracer = "function_graph", > + .tracer = DEFAULT_TRACER, > .target = { .uid = UINT_MAX, }, > }; > const char * const ftrace_usage[] = { > @@ -231,9 +231,6 @@ int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused) > if (ret < 0) > goto out_delete_evlist; > > - if (ftrace.tracer == NULL) > - ftrace.tracer = DEFAULT_TRACER; > - > ret = __cmd_ftrace(&ftrace, argc, argv); > > out_delete_evlist: > -- > 2.7.4