public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: William Blough <devel@blough.us>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon-usb: Fix coding style issues
Date: Fri, 27 Jan 2017 08:29:07 +0100	[thread overview]
Message-ID: <20170127072907.GA29616@kroah.com> (raw)
In-Reply-To: <20170127034559.GA5241@blough.us>

On Thu, Jan 26, 2017 at 10:46:02PM -0500, William Blough wrote:
> Wrap lines that exceed 80 characters.
> 
> Signed-off-by: William Blough <devel@blough.us>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 9a7858a..6b86bfb 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
>  				/* Disable all interrupts except CHHLTD */
>  				hcintmsk.u32 = 0;
>  				hcintmsk.s.chhltdmsk = 1;
> -				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCINTMSKX(channel, usb->index),
> -						     hcintmsk.u32);
> +				cvmx_usb_write_csr32(
> +						usb,
> +						CVMX_USBCX_HCINTMSKX(
> +								channel,
> +								usb->index),
> +						hcintmsk.u32);
>  				usbc_hcchar.s.chdis = 1;
> -				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCCHARX(channel, usb->index),
> -						     usbc_hcchar.u32);
> +				cvmx_usb_write_csr32(
> +						usb,
> +						CVMX_USBCX_HCCHARX(
> +								channel,
> +								usb->index),
> +						usbc_hcchar.u32);
>  				return 0;
>  			} else if (usbc_hcint.s.xfercompl) {
>  				/*

That's horrid, the original code looks better, please leave it as-is.

thanks,

greg k-h

      reply	other threads:[~2017-01-27  7:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27  3:46 [PATCH] staging: octeon-usb: Fix coding style issues William Blough
2017-01-27  7:29 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170127072907.GA29616@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=devel@blough.us \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox