From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbdA0H25 (ORCPT ); Fri, 27 Jan 2017 02:28:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44358 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754038AbdA0H24 (ORCPT ); Fri, 27 Jan 2017 02:28:56 -0500 Date: Fri, 27 Jan 2017 08:29:07 +0100 From: Greg Kroah-Hartman To: William Blough Cc: Aaro Koskinen , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: octeon-usb: Fix coding style issues Message-ID: <20170127072907.GA29616@kroah.com> References: <20170127034559.GA5241@blough.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170127034559.GA5241@blough.us> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 10:46:02PM -0500, William Blough wrote: > Wrap lines that exceed 80 characters. > > Signed-off-by: William Blough > --- > drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c > index 9a7858a..6b86bfb 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/octeon-hcd.c > @@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel) > /* Disable all interrupts except CHHLTD */ > hcintmsk.u32 = 0; > hcintmsk.s.chhltdmsk = 1; > - cvmx_usb_write_csr32(usb, > - CVMX_USBCX_HCINTMSKX(channel, usb->index), > - hcintmsk.u32); > + cvmx_usb_write_csr32( > + usb, > + CVMX_USBCX_HCINTMSKX( > + channel, > + usb->index), > + hcintmsk.u32); > usbc_hcchar.s.chdis = 1; > - cvmx_usb_write_csr32(usb, > - CVMX_USBCX_HCCHARX(channel, usb->index), > - usbc_hcchar.u32); > + cvmx_usb_write_csr32( > + usb, > + CVMX_USBCX_HCCHARX( > + channel, > + usb->index), > + usbc_hcchar.u32); > return 0; > } else if (usbc_hcint.s.xfercompl) { > /* That's horrid, the original code looks better, please leave it as-is. thanks, greg k-h