From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754475AbdA0IPU (ORCPT ); Fri, 27 Jan 2017 03:15:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:44784 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754239AbdA0IO1 (ORCPT ); Fri, 27 Jan 2017 03:14:27 -0500 Date: Fri, 27 Jan 2017 09:00:08 +0100 From: Johannes Thumshirn To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , Jens Axboe , Linux NVMe Mailinglist , Linux Kernel Mailinglist Subject: Re: [PATCH] nvme: make nvmf_register_transport require a create_ctrl callback Message-ID: <20170127080008.GA4501@linux-x5ow.site> References: <20170126152228.15330-1-jthumshirn@suse.de> <2cc9ed5f-c9af-fd9d-2c90-04541ceebab6@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2cc9ed5f-c9af-fd9d-2c90-04541ceebab6@grimberg.me> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 06:30:47PM +0200, Sagi Grimberg wrote: > > > static void __exit nvme_fc_exit_module(void) > >diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c > >index 557f29b..80f3695 100644 > >--- a/drivers/nvme/host/rdma.c > >+++ b/drivers/nvme/host/rdma.c > >@@ -2063,8 +2063,7 @@ static int __init nvme_rdma_init_module(void) > > return ret; > > } > > > >- nvmf_register_transport(&nvme_rdma_transport); > >- return 0; > >+ return = nvmf_register_transport(&nvme_rdma_transport); Gah typo and I had only fc enabled in my .config. Sorry. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850