From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932834AbdA0Mau (ORCPT ); Fri, 27 Jan 2017 07:30:50 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:40149 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932803AbdA0M3q (ORCPT ); Fri, 27 Jan 2017 07:29:46 -0500 Date: Fri, 27 Jan 2017 15:29:30 +0300 From: Dan Carpenter To: mrossibellom@gmail.com Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] greybus: Fix coding stye error Message-ID: <20170127122930.GL4149@mwanda> References: <1485511881-8693-1-git-send-email-mrossibellom@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485511881-8693-1-git-send-email-mrossibellom@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibellom@gmail.com wrote: > From: Maxime Rossi Bellom > > Split line before funtion argument. > > Error was reported by checkpatch.pl as > WARNING: line over 80 characters > > Signed-off-by: Maxime Rossi Bellom > --- > drivers/staging/greybus/fw-management.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c > index 3cd6cf0..d88117e 100644 > --- a/drivers/staging/greybus/fw-management.c > +++ b/drivers/staging/greybus/fw-management.c > @@ -516,7 +516,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd, > */ > fw_mgmt->mode_switch_started = true; > > - ret = gb_interface_request_mode_switch(fw_mgmt->connection->intf); > + ret = gb_interface_request_mode_switch( > + fw_mgmt->connection->intf); Another option would be to change the name from gb_interface_request_mode_switch() to gb_get_mode_switch() or something along those lines. It requires understanding the code to say what a good name is. regards, dan carpenter