From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932564AbdA0NRB (ORCPT ); Fri, 27 Jan 2017 08:17:01 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34517 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754447AbdA0NQd (ORCPT ); Fri, 27 Jan 2017 08:16:33 -0500 Date: Fri, 27 Jan 2017 14:08:06 +0100 From: Johan Hovold To: Dan Carpenter Cc: Johan Hovold , mrossibellom@gmail.com, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] greybus: Fix coding stye error Message-ID: <20170127130806.GH3560@localhost> References: <1485511881-8693-1-git-send-email-mrossibellom@gmail.com> <20170127122930.GL4149@mwanda> <20170127123905.GF3560@localhost> <20170127124721.GP4201@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170127124721.GP4201@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > The name sucks is what I'm saying. Please fix it eventually. I disagree. The name uses a common prefix that reflects the object it is working on. This should not be changed. As it is currently named, the function is also self-documenting. Trying to abbreviate the name just to meet a 80 col limit (when there are alternatives) is just silly. Johan