From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbdA0ONc (ORCPT ); Fri, 27 Jan 2017 09:13:32 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:20441 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754845AbdA0ONP (ORCPT ); Fri, 27 Jan 2017 09:13:15 -0500 Date: Fri, 27 Jan 2017 17:13:01 +0300 From: Dan Carpenter To: Johan Hovold Cc: devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mrossibellom@gmail.com Subject: Re: [PATCH] greybus: Fix coding stye error Message-ID: <20170127141301.GM4149@mwanda> References: <1485511881-8693-1-git-send-email-mrossibellom@gmail.com> <20170127122930.GL4149@mwanda> <20170127123905.GF3560@localhost> <20170127124721.GP4201@mwanda> <20170127130806.GH3560@localhost> <20170127132447.GQ4201@mwanda> <20170127135315.GI3560@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170127135315.GI3560@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I guess I'm not a fan of really long prefixes... I've complained before to other people so don't feel special. Prefixes are something that people add without thinking as if they always make the code better and I do blame JAVA influence for this... The "_interface" really doesn't add anything because that's always the first parameter that we pass. It's just filler. I think "try" is better than "request" probably. Request is regularly used as a noun and try never is. But I don't care at this point. regards, dan carpenter