public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxime Rossi Bellom <mrossibellom@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johan Hovold <johan@kernel.org>,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] greybus: Fix coding stye error
Date: Fri, 27 Jan 2017 15:37:12 +0100	[thread overview]
Message-ID: <20170127143710.GB14447@LF005> (raw)
In-Reply-To: <20170127141301.GM4149@mwanda>

On Fri, Jan 27, 2017 at 05:13:01PM +0300, Dan Carpenter wrote:
> I guess I'm not a fan of really long prefixes...  I've complained before
> to other people so don't feel special.  Prefixes are something that
> people add without thinking as if they always make the code better and
> I do blame JAVA influence for this...
> 
> The "_interface" really doesn't add anything because that's always the
> first parameter that we pass.  It's just filler.
> 
> I think "try" is better than "request" probably.  Request is regularly
> used as a noun and try never is.
> 
> But I don't care at this point.
> 
> regards,
> dan carpenter
>

I don't feel confortable removing a word in the function name as I don't 
fully understand the code.

What about shorting interface into intf as it is used in connection->intf ?

Johan, what do you mean by using connection->intf in this case ? Are you
talking about a global variable usable in this context ?

Thanks,
Maxime

  reply	other threads:[~2017-01-27 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 10:11 [PATCH] greybus: Fix coding stye error mrossibellom
2017-01-27 10:17 ` Greg KH
2017-01-27 12:29 ` Dan Carpenter
2017-01-27 12:39   ` Johan Hovold
2017-01-27 12:47     ` Dan Carpenter
2017-01-27 13:08       ` Johan Hovold
2017-01-27 13:24         ` Dan Carpenter
2017-01-27 13:53           ` Johan Hovold
2017-01-27 14:13             ` Dan Carpenter
2017-01-27 14:37               ` Maxime Rossi Bellom [this message]
2017-01-27 14:43                 ` Dan Carpenter
2017-01-27 14:46                   ` Maxime Rossi Bellom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170127143710.GB14447@LF005 \
    --to=mrossibellom@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox