From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754976AbdA0Oha (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Jan 2017 09:37:30 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34809 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754546AbdA0OhQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Jan 2017 09:37:16 -0500
Date: Fri, 27 Jan 2017 15:37:12 +0100
From: Maxime Rossi Bellom <mrossibellom@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johan Hovold <johan@kernel.org>, devel@driverdev.osuosl.org,
        greybus-dev@lists.linaro.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] greybus: Fix coding stye error
Message-ID: <20170127143710.GB14447@LF005>
References: <1485511881-8693-1-git-send-email-mrossibellom@gmail.com>
 <20170127122930.GL4149@mwanda>
 <20170127123905.GF3560@localhost>
 <20170127124721.GP4201@mwanda>
 <20170127130806.GH3560@localhost>
 <20170127132447.GQ4201@mwanda>
 <20170127135315.GI3560@localhost>
 <20170127141301.GM4149@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170127141301.GM4149@mwanda>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 27, 2017 at 05:13:01PM +0300, Dan Carpenter wrote:
> I guess I'm not a fan of really long prefixes...  I've complained before
> to other people so don't feel special.  Prefixes are something that
> people add without thinking as if they always make the code better and
> I do blame JAVA influence for this...
> 
> The "_interface" really doesn't add anything because that's always the
> first parameter that we pass.  It's just filler.
> 
> I think "try" is better than "request" probably.  Request is regularly
> used as a noun and try never is.
> 
> But I don't care at this point.
> 
> regards,
> dan carpenter
>

I don't feel confortable removing a word in the function name as I don't 
fully understand the code.

What about shorting interface into intf as it is used in connection->intf ?

Johan, what do you mean by using connection->intf in this case ? Are you
talking about a global variable usable in this context ?

Thanks,
Maxime