Re: [PATCH 4/4] efi/x86: add debug code to print cooked memmap

Ard Biesheuvel
2017-01-12T16:18:24Z

On 12 January 2017 at 09:41, Dave Young <dyoung@redhat.com> wrote:
> It is not obvious if the reserved boot area are added correctly, add a
> efi_print_memmap to print the new memmap.
>
> Signed-off-by: Dave Young <dyoung@redhat.com>

This sounds useful regardless of the other patches in this series:

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Note that it is appropriate to keep this x86 specific, since we never
modify the memory map on ARM (except for the sorting that occurs in
the stub)

> ---
> arch/x86/platform/efi/efi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- linux-x86.orig/arch/x86/platform/efi/efi.c
> +++ linux-x86/arch/x86/platform/efi/efi.c
> @@ -873,6 +873,11 @@ static void __init __efi_enter_virtual_m
> return;
> }
>
> + if (efi_enabled(EFI_DBG)) {
> + pr_info("EFI runtime memory map:\n");
> + efi_print_memmap();
> + }
> +
> BUG_ON(!efi.systab);
>
> if (efi_setup_page_tables(pa, 1 << pg_shift)) {
>
>