From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Input: leds - force the LED status after .probe()
Date: Fri, 27 Jan 2017 19:19:25 +0100 [thread overview]
Message-ID: <20170127181925.GI13244@mail.corp.redhat.com> (raw)
In-Reply-To: <20170127173400.GA9511@var.bordeaux.inria.fr>
On Jan 27 2017 or thereabouts, Samuel Thibault wrote:
> Benjamin Tissoires, on Fri 27 Jan 2017 18:13:18 +0100, wrote:
> > Once the host has set the initial setting of the LEDs after a new
> > USB keyboard gets connected, they appear to have a SET_IDLE command
> > sent which turns of the LEDs.
> > This means that the initial step of setting the LEDs on a keyboard is
> > just reset once .probe() finishes.
> > To be sure we set the LEDs, start a delayed task to try to resend
> > them after 1 sec.
>
> If there is such issue, I'd say fix the issue (what is sending
> SET_IDLE?) instead of working around it.
>
That is the question. I am not even sure who sends the SET_IDLE, and if
this is something that can be controlled without disturbing too many
devices. I'll dig further then.
Cheers,
Benjamin
next prev parent reply other threads:[~2017-01-27 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 17:13 [PATCH 0/4] TTY: fix Caps Lock LED Benjamin Tissoires
2017-01-27 17:13 ` [PATCH 1/4] tty/vt/keyboard: use defined macros for masks Benjamin Tissoires
2017-01-27 17:18 ` Samuel Thibault
2017-01-27 17:13 ` [PATCH 2/4] tty/vt/keyboard: Fix Caps Lock LED on major distributions Benjamin Tissoires
2017-01-27 17:25 ` Samuel Thibault
2017-01-27 17:29 ` Dmitry Torokhov
2017-01-27 17:13 ` [PATCH 3/4] tty/vt/keyboard: reset the LEDs state at each console change Benjamin Tissoires
2017-01-27 17:31 ` Samuel Thibault
2017-01-27 18:18 ` Benjamin Tissoires
2017-01-27 17:13 ` [PATCH 4/4] Input: leds - force the LED status after .probe() Benjamin Tissoires
2017-01-27 17:34 ` Samuel Thibault
2017-01-27 18:19 ` Benjamin Tissoires [this message]
2017-01-27 17:23 ` [PATCH 0/4] TTY: fix Caps Lock LED Samuel Thibault
2017-01-27 18:34 ` Benjamin Tissoires
2017-01-27 18:47 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127181925.GI13244@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox