From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbdA0TNT (ORCPT ); Fri, 27 Jan 2017 14:13:19 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33534 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdA0TNB (ORCPT ); Fri, 27 Jan 2017 14:13:01 -0500 Date: Fri, 27 Jan 2017 20:12:47 +0100 From: Pavel Machek To: Guenter Roeck Cc: Zhang Rui , Pali =?iso-8859-1?Q?Roh=E1r?= , sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, fabio.estevam@nxp.com Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Message-ID: <20170127191247.GC20571@amd> References: <20170124175800.GA15070@amd> <20170124184526.GA25056@roeck-us.net> <20170125111233.GB3912@amd> <20170125120918.GA7936@pali> <1485481030.2469.15.camel@intel.com> <1485488382.2469.27.camel@intel.com> <9146145b-7e21-c4de-a9cd-dad7bc74ee7a@roeck-us.net> <1485528033.2469.61.camel@intel.com> <20170127172039.GA2498@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iFRdW5/EC4oqxDHL" Content-Disposition: inline In-Reply-To: <20170127172039.GA2498@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iFRdW5/EC4oqxDHL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2017-01-27 09:20:39, Guenter Roeck wrote: > On Fri, Jan 27, 2017 at 10:40:33PM +0800, Zhang Rui wrote: > > > >=20 > > > > If thermal zone I/F is used, we can not change it's 'type' name to > > > > be > > > > compatible with new hwmon API. > > > >=20 > > > You mean you can not fix the name to be compatible with libsensors. > > >=20 > >=20 > > We can try to convert it to a libsensor-compatible string, either for > > hwmon only, or for both thermal and hwmon. But this is an ABI change, > > right? >=20 > Let's go back to the basics. >=20 > Fact is that the thermal subsystem registers hwmon devices with 'name' > attributes which violate the documented hardware monitoring ABI. > I think we can consider this undisputed. >=20 > The rest is pretty much all opinion. >=20 > Is a change in a driver to stop violating a documented ABI an ABI change > or a bug fix ? In other words, does a driver violating a documented ABI > make that ABI violation part of the ABI ? It can be both. But "no regressions" takes precedence over "documentation". > Quite interesting questions. My take is that it is a bug fix, others > apparently have the strong opinion that potential users of such an ABI > violation have priority, and that a violation of a documented ABI _does_ > make this violation part of the ABI. "Potential" users you can work around. "Real" users are problem. And yes, I have strong opinion about release candidates. Outside that, see my next mail. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --iFRdW5/EC4oqxDHL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliLm68ACgkQMOfwapXb+vJzLgCghD6Js6boy2DvwoCjrUxWygNM IwQAn2qZk/EK8JBnxMecaKoZc7iYKzIi =8UjF -----END PGP SIGNATURE----- --iFRdW5/EC4oqxDHL--