From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750847AbdA1G7t (ORCPT ); Sat, 28 Jan 2017 01:59:49 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19367 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750719AbdA1G7k (ORCPT ); Sat, 28 Jan 2017 01:59:40 -0500 Date: Sat, 28 Jan 2017 09:59:27 +0300 From: Dan Carpenter To: Doug Ledford Cc: Bart Van Assche , "christophe.jaillet@wanadoo.fr" , "hal.rosenstock@gmail.com" , "sean.hefty@intel.com" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] IB/cma: Fix reversed test Message-ID: <20170128065927.GP4149@mwanda> References: <20170127131535.19918-1-christophe.jaillet@wanadoo.fr> <1485552696.13218.0.camel@sandisk.com> <1485561952.2432.31.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485561952.2432.31.camel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 07:05:52PM -0500, Doug Ledford wrote: > > Do you think this patch needs "Fixes:" and "Cc: stable" tags? > > It does not. We always should have fixes tags. When I'm reviewing, I try to look up the patch which introduced the bug so I can figure out what the intent was. Having a Fixes tag speeds up my work. Looking at how the bug was introduced sometimes helps to prevent bugs from recurring in the future. For example, I've seen several bugs introduced because the right people weren't on the CC to review it. For this particular bug it feels like probably this bug could have been detected with more testing. I doubt it would have made it into a released kernel. Also it let's you CC the original authors and hopefully they can Ack it. regards, dan carpenter