From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751373AbdA1LOh convert rfc822-to-8bit (ORCPT ); Sat, 28 Jan 2017 06:14:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:54982 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbdA1LOa (ORCPT ); Sat, 28 Jan 2017 06:14:30 -0500 Date: Sat, 28 Jan 2017 12:13:46 +0100 From: Jean Delvare To: Wolfram Sang Cc: Ricardo Ribalda Delgado , Andy Shevchenko , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: piix4: Fix request_region size Message-ID: <20170128121346.1e530c1c@endymion> In-Reply-To: <20170128110021.GA1604@katana> References: <20170127145930.13055-1-ricardo.ribalda@gmail.com> <1485592582.4916.1.camel@suse.de> <20170128110021.GA1604@katana> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Sat, 28 Jan 2017 12:00:21 +0100, Wolfram Sang wrote: > > > >  /* count for request_region */ > > > -#define SMBIOSIZE 8 > > > +#define SMBIOSIZE 9 > > > > Are you certain that all supported devices have this extra register? > > Isn't it better to have a potentially unused register mapped than a > potentially used register unmapped? My concern is that the region request could fail due to a conflict with another device, if the physical I/O region is only 8 and we try to request 9. -- Jean Delvare SUSE L3 Support