From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbdA2PeA (ORCPT ); Sun, 29 Jan 2017 10:34:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:36653 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbdA2Pdz (ORCPT ); Sun, 29 Jan 2017 10:33:55 -0500 Date: Sun, 29 Jan 2017 07:15:31 -0800 From: Davidlohr Bueso To: hpa@zytor.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, paulmck@linux.vnet.ibm.com, longman@redhat.com, mingo@kernel.org, peterz@infradead.org, torvalds@linux-foundation.org Cc: linux-tip-commits@vger.kernel.org Subject: [PATCH -tip] sched/wake_q: Clarify queue reinit Message-ID: <20170129151531.GA2444@linux-80c1.suse> References: <1485052415-9611-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As of bcc9a76d5ac (locking/rwsem: Reinit wake_q after use), the comment regarding the list reinitialization no longer applies, update it with the new wake_q_init() helper. Signed-off-by: Davidlohr Bueso --- include/linux/sched.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 3640bde9f982..c0bc626c531f 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -998,8 +998,8 @@ enum cpu_idle_type { * * The DEFINE_WAKE_Q macro declares and initializes the list head. * wake_up_q() does NOT reinitialize the list; it's expected to be - * called near the end of a function, where the fact that the queue is - * not used again will be easy to see by inspection. + * called near the end of a function. Otherwise, the list can be + * re-initialized for later re-use by wake_q_init(). * * Note that this can cause spurious wakeups. schedule() callers * must ensure the call is done inside a loop, confirming that the -- 2.6.6