From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Chen-Yu Tsai <wens@csie.org>,
Linus Walleij <linus.walleij@linaro.org>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Andre Przywara <andre.przywara@arm.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
dmaengine@vger.kernel.org, alsa-devel@alsa-project.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5
Date: Mon, 30 Jan 2017 10:03:07 +0100 [thread overview]
Message-ID: <20170130090307.mmeab5ybfxaeicq2@lukather> (raw)
In-Reply-To: <20170129023331.62106-4-icenowy@aosc.xyz>
[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]
Hi,
On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote:
> As the CCU in the Allwinner H5 SoC is very similar to the one in H3,
> rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5
> support.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> The original PATCH v2 3/9 is splited into two patches in v3, this one renames
> the H3 driver to h3-h5, and the next one finally add H5 support to it.
>
> drivers/clk/sunxi-ng/Kconfig | 4 +-
> drivers/clk/sunxi-ng/Makefile | 2 +-
> .../sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} | 42 +++---
> .../sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} | 10 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------------
> include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 ++++++++++++++++++++
> include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +--------------
> include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++
> 8 files changed, 282 insertions(+), 274 deletions(-)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} (96%)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} (88%)
> mode change 100644 => 120000 include/dt-bindings/clock/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h
> mode change 100644 => 120000 include/dt-bindings/reset/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h
Please generate your patches with -M
> -static void __init sun8i_h3_ccu_setup(struct device_node *node)
> +static void __init sunxi_h3_h5_ccu_init(struct device_node *node,
> + const struct sunxi_ccu_desc *desc)
> {
The indentation should be on the opening parenthesis.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-01-30 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170129023331.62106-1-icenowy@aosc.xyz>
[not found] ` <20170129023331.62106-6-icenowy@aosc.xyz>
2017-01-30 1:42 ` [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi André Przywara
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:06 ` Maxime Ripard
[not found] ` <20170129023331.62106-4-icenowy@aosc.xyz>
2017-01-30 9:03 ` Maxime Ripard [this message]
[not found] ` <20170129023331.62106-5-icenowy@aosc.xyz>
2017-01-30 9:04 ` [PATCH v3 04/10] clk: sunxi-ng: add support for Allwinner H5 SoC Maxime Ripard
[not found] ` <20170129023331.62106-7-icenowy@aosc.xyz>
2017-01-30 9:09 ` [PATCH v3 06/10] clk: sunxi-ng: remove transitional headers for dt-bindings Maxime Ripard
[not found] ` <20170129023331.62106-2-icenowy@aosc.xyz>
2017-01-30 15:23 ` [PATCH v3 01/10] drivers: pinctrl: add driver for Allwinner H5 SoC Linus Walleij
[not found] ` <20170129023331.62106-9-icenowy@aosc.xyz>
2017-01-30 16:42 ` [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Vinod Koul
[not found] ` <3729521485800635@web23g.yandex.ru>
2017-01-31 3:32 ` Vinod Koul
2017-02-05 7:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130090307.mmeab5ybfxaeicq2@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=icenowy@aosc.xyz \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=perex@perex.cz \
--cc=vinod.koul@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox