From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753367AbdA3MsK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 07:48:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46614 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753149AbdA3Mrw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 07:47:52 -0500
Date: Mon, 30 Jan 2017 13:38:58 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros
 for tracepoints iteration
Message-ID: <20170130123858.GA11068@krava>
References: <1485765328-21787-1-git-send-email-treeze.taeung@gmail.com>
 <20170130090812.GD22029@krava>
 <bc0b5c66-0de0-e380-6925-7d4f4d9fccb7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bc0b5c66-0de0-e380-6925-7d4f4d9fccb7@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 30 Jan 2017 12:39:03 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:

SNIP

> > looks almost the same as for_each_event_system macro,
> > what's the difference other than 'ftrace' check?
> 
> Little thing.
> In parse-events.c for_each_event macro contains
> tp_event_has_id() function But this function isn't used in
> util/trace-event-info.c
> 
> > also why's one 'file' and the other 'system'? looks
> 
> Just, I follow the name of each function that use the macros..
> 
> > like we coud have just one macro in here
> > 
> 
> I understood. :)
> How about this ?


looks ok, but can't apply it.. it's probably mangled

jirka