From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Maksymilian Piechota <maksymilianpiechota@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement
Date: Mon, 30 Jan 2017 17:44:23 +0100 [thread overview]
Message-ID: <20170130164423.GA12941@kroah.com> (raw)
In-Reply-To: <20170130163142.GA9425@maks-debian.localdomain>
On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Statements should start on a tabstop
>
> Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 16fb2d3..2d67125 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1308,7 +1308,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> hw->sniffhdr = 0;
> wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> } else
> - if ((msg->wlanheader.status ==
> + if ((msg->wlanheader.status ==
> P80211ENUM_msgitem_status_data_ok)
> && (msg->wlanheader.data == P80211ENUM_truth_true)) {
> hw->sniffhdr = 1;
Hm, this all doesn't look correct now, does it? Please fix up the whole
if statement here.
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-30 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 16:31 [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement Maksymilian Piechota
2017-01-30 16:44 ` Greg Kroah-Hartman [this message]
2017-01-31 4:00 ` Joe Perches
2017-01-31 11:04 ` Maksymilian Piechota
2017-01-31 11:18 ` Joe Perches
2017-01-31 11:33 ` Maksymilian Piechota
2017-01-31 12:07 ` Joe Perches
2017-01-31 12:20 ` Maksymilian Piechota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130164423.GA12941@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maksymilianpiechota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox