From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbdA3ST1 (ORCPT ); Mon, 30 Jan 2017 13:19:27 -0500 Received: from mail-qt0-f169.google.com ([209.85.216.169]:33427 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605AbdA3STZ (ORCPT ); Mon, 30 Jan 2017 13:19:25 -0500 Date: Mon, 30 Jan 2017 13:19:22 -0500 From: Sean Paul To: John Keeping Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 08/24] drm/rockchip: dw-mipi-dsi: respect message flags Message-ID: <20170130181922.GI20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-9-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170129132444.25251-9-john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 01:24:28PM +0000, John Keeping wrote: > Instead of always sending commands in LP mode, respect the > MIPI_DSI_MSG_USE_LPM flag to decide how to send each message. Also > request acks if MIPI_DSI_MSG_REQ_ACK is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 92dbc3e56603..15d33c3c8cb7 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -542,6 +542,19 @@ static int dw_mipi_dsi_host_detach(struct mipi_dsi_host *host, > return 0; > } > > +static void dw_mipi_message_config(struct dw_mipi_dsi *dsi, > + const struct mipi_dsi_msg *msg) > +{ > + u32 val = 0; > + > + if (msg->flags & MIPI_DSI_MSG_REQ_ACK) > + val |= EN_ACK_RQST; > + if (msg->flags & MIPI_DSI_MSG_USE_LPM) > + val |= CMD_MODE_ALL_LP; > + > + dsi_write(dsi, DSI_CMD_MODE_CFG, val); > +} > + > static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > { > int ret; > @@ -634,6 +647,8 @@ static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > struct dw_mipi_dsi *dsi = host_to_dsi(host); > int ret; > > + dw_mipi_message_config(dsi, msg); > + > switch (msg->type) { > case MIPI_DSI_DCS_SHORT_WRITE: > case MIPI_DSI_DCS_SHORT_WRITE_PARAM: > @@ -745,7 +760,6 @@ static void dw_mipi_dsi_command_mode_config(struct dw_mipi_dsi *dsi) > { > dsi_write(dsi, DSI_TO_CNT_CFG, HSTX_TO_CNT(1000) | LPRX_TO_CNT(1000)); > dsi_write(dsi, DSI_BTA_TO_CNT, 0xd00); > - dsi_write(dsi, DSI_CMD_MODE_CFG, CMD_MODE_ALL_LP); > dsi_write(dsi, DSI_MODE_CFG, ENABLE_CMD_MODE); > } > > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS