From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754172AbdA3StU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 13:49:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55114 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753949AbdA3StS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 13:49:18 -0500
Date: Mon, 30 Jan 2017 19:49:15 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com,
        acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        mhiramat@kernel.org, rui.teng@linux.vnet.ibm.com,
        sukadev@linux.vnet.ibm.com
Subject: Re: [PATCH] perf: fix topology test on systems with sparse CPUs
Message-ID: <20170130184915.GC28444@krava>
References: <290bf2031885722414cb1ae031869094a18b0580.1485794959.git.jstancek@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <290bf2031885722414cb1ae031869094a18b0580.1485794959.git.jstancek@redhat.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 30 Jan 2017 18:49:19 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 30, 2017 at 05:53:34PM +0100, Jan Stancek wrote:
> Topology test fails on systems with sparse CPUs, e.g.

SNIP

>  
> -	for (i = 0; i < nr; i++) {
> -		ret = build_cpu_topo(tp, i);
> +	for (i = 0; i < tp->cpu_nr; i++) {
> +		cpu = map->map[i];

no need for cpu variable

jirka

> +		ret = build_cpu_topo(tp, cpu);
>  		if (ret < 0)
>  			break;