From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Loic Pallardy <loic.pallardy@st.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH] remoteproc: Move rproc_delete_debug_dir() to rproc_del()
Date: Mon, 30 Jan 2017 14:13:19 -0800 [thread overview]
Message-ID: <20170130221319.GE31134@builder> (raw)
In-Reply-To: <20170130220119.GD31134@builder>
On Mon 30 Jan 14:01 PST 2017, Bjorn Andersson wrote:
> On Mon 23 Jan 17:48 PST 2017, Sarangdhar Joshi wrote:
>
> > The "remoteproc{0,1...}" sysfs entries are added in
> > rproc_add() and deleted in rproc_type_release() instead of
> > in rproc_del(). That leaves these lingering entries sticking
> > around after we return from rproc_del(). Move the
> > rproc_delete_debug_dir() to rproc_del() to fix this.
> >
> > Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
>
> I moved the rproc_delete_debug_dir() below the list_del() region to
> allow reuse of the critical region in the upcoming "deleted" patch.
>
Never mind, I failed at reading. I re-applied this as is.
Regards,
Bjorn
> Applied, thank you.
>
> Regards,
> Bjorn
>
> > ---
> > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > index 953ee29..78200a7 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -1315,8 +1315,6 @@ static void rproc_type_release(struct device *dev)
> >
> > dev_info(&rproc->dev, "releasing %s\n", rproc->name);
> >
> > - rproc_delete_debug_dir(rproc);
> > -
> > idr_destroy(&rproc->notifyids);
> >
> > if (rproc->index >= 0)
> > @@ -1491,6 +1489,8 @@ int rproc_del(struct rproc *rproc)
> > if (rproc->auto_boot)
> > rproc_shutdown(rproc);
> >
> > + rproc_delete_debug_dir(rproc);
> > +
> > /* the rproc is downref'ed as soon as it's removed from the klist */
> > mutex_lock(&rproc_list_mutex);
> > list_del(&rproc->node);
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
prev parent reply other threads:[~2017-01-31 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 1:48 [PATCH] remoteproc: Move rproc_delete_debug_dir() to rproc_del() Sarangdhar Joshi
2017-01-30 22:01 ` Bjorn Andersson
2017-01-30 22:13 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130221319.GE31134@builder \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
--cc=ssantosh@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).