From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbdAaBYK (ORCPT ); Mon, 30 Jan 2017 20:24:10 -0500 Received: from gate.crashing.org ([63.228.1.57]:59096 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbdAaBYI (ORCPT ); Mon, 30 Jan 2017 20:24:08 -0500 Date: Mon, 30 Jan 2017 19:22:33 -0600 From: Segher Boessenkool To: Christian Kujau Cc: Christophe Leroy , linux-kernel@vger.kernel.org, Scott Wood , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH RFC] powerpc/32: fix handling of stack protector with recent GCC Message-ID: <20170131012233.GC21840@gate.crashing.org> References: <20170116090031.4843668B50@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 04:12:53PM -0800, Christian Kujau wrote: > On Mon, 16 Jan 2017, Christophe Leroy wrote: > > Since 2005, powerpc GCC doesn't manage anymore __stack_chk_guard as > > a global variable but as some value located at -0x7008(r2) > > Is this still an "RFC" or is there a chance that this will land in 4.10? Older GCC (i.e. not ancient, but < 7 currently; the new options will be backported to 5 and 6) doesn't always use TLS stack canaries either: it depends on how your GCC is configured. The kernel will have to detect if the GCC it uses knows the new options, and if not, if it still wants to use SSP it has to detect what GCC uses to get at the canary. This patch as-is won't work. Segher