From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbdAaK2x (ORCPT ); Tue, 31 Jan 2017 05:28:53 -0500 Received: from mail-cys01nam02on0083.outbound.protection.outlook.com ([104.47.37.83]:30319 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751488AbdAaK2o (ORCPT ); Tue, 31 Jan 2017 05:28:44 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Vadim.Lomovtsev@caviumnetworks.com; Date: Tue, 31 Jan 2017 02:28:30 -0800 From: Vadim Lomovtsev To: Bjorn Helgaas CC: , , , , , Subject: Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization Message-ID: <20170131102830.GA13854@localhost.localdomain> References: <1485793552-12614-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <20170130211236.GW20550@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170130211236.GW20550@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR20CA0013.namprd20.prod.outlook.com (10.171.151.151) To BN3PR07MB2643.namprd07.prod.outlook.com (10.167.5.23) X-MS-Office365-Filtering-Correlation-Id: 2251520f-d33e-4286-1ec6-08d449c3ea9d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN3PR07MB2643; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2643;3:D/JqbKVcVb+vVhVLtEDJW+OMhhDtQk1NG+4mgXepJX8EMh9IIsHanbsqqsZqW7nUwd4J1lLd1EmM4MfodzNS0WWRdJYUTEgqBJtnW0+27r3ERYzFtTaACCrDCVmgiA1m40n9a2sBg9CIMk4C6Fp4emLTfGVdvRjI6FmZDK1Psq2jS4Aeu1BMdGsXIrKNi7P6RHeMPzao4qUKmETDp/8eUoEG/4FR53ivH0ItD3Fs3RvwcSmbzBHhqIPaTMicsCTX6hXfZJ9ovNNB0rMZMQEXtg==;25:Ru3tLeZuGB/Q+sTVNu4kwA3uQ1eIWaK5otabqoqt1Ttgbtk3hnijtCu27GNpryFNKC3Fay+zfpMGJGykOXybZzmpkUFRjAolr6fIglFxYXz8OpUn5YoNVINPfPG2KZPf1y4QdkO17A63kagzVnVOfo+fmqPExPb2aRNxX+YiJ74FnHCsBLVAK2O1pSaapTV0vBgkbBGoatuD8Gpscf4TGLyL66p+Jiv5SEp3R87pPbYfSBSJ4yAkIcy8SgIx1KXnxPHHp18O+ZhT9FKMz3/RdkojcfE07kHkmLVE3CQgzcjq6lVlZo5eeW6fnp/tkM+pMBiAJgJYVo8eXbqP9azpa391o0+VlkstlJPAMDQAEKtvEmx+sDrlYPcUqYOLr+jk1TbEE+6Pu5Se1MUGxGDKWUxvwR9TFUF29pLRIljRFAwS8vuPilTAGBM/+rJpXLxP8wI9dVPMuDC9hf5ArtUK+w== X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2643;31:1pyjFfNUonFap+XCKXzI2pnR8G3MuoyT3qaUcIK8wXAXZhbnmcb7gDgVEmU7Fd3PL+Ty9llJTLfnTm6AUxtqoRFd+KE5PiMtp1JZqg0EKBJe/HJ/Us5VOsWjh1iViWXCMJSZxf7HhqkKcU094mUkj7rdgaRHrbMeewgoSeWPOHH2qQHpDRauR/qhxyAIQ+Ax0daH9YJDKhAPLUk/Oub9UcUgFEXfauNzOpbGbEcfFMEEvWU4U+6dGoyFSDkx13ZcGLVeVQX5pFzr/S+UnpCJSA==;20:KxK14uaeBMYRqnZ4rR0Hy6tWrIyODbhTtdasu8wgCA960plamn07q30tXLwg01FpEWvxO8Ver2rALq9nW4D1Yrohr6m0YQGxNpmCQtOlE18KWZArovdH8Oq+wAiu8E0zXRjOzV9i2w8I3P1CMTQw64Q4aFZbONrvGUtaiz3eJq3J9BBDO74amPkLAxqwT40MD0d7sPdA4ThUjnI8ncVol/0YTzi02EyeEmJcEy2df2SBDOXB0jzwgKrrHBBO4TZYbliALroqYsRX/ZB/0IV/sSuOd+RKzZLWBgXB0YjZpmawqEx2Hn27r/FYQ1cH2GMoP6QTlzxsSMKh1rX/WtWdFVKqOO89eXzeUIcOfzL1BgTGraLlzTmJ9Eg2cOE8Asa2GIF2IHboeVzOLpoRlqJx1otN731X7QYpoGS02bRPCclEJMzNXdfATBW04xR/5h2LwDr81bG9r5WWlsN38MCVUKecyVK6MRKmHIa5O7GYhenxjW7xUkcRUuM/eRqtfF4HT+JOiUskR/Bwo868LoH3gIXyI+RxHZdPrlgeIuD9zrHZWULYA+lz5woXth0PoweCNlQL84fZSbldKxziD+dmwv0Sjcz4Xt+G2ewrqWwQR7Y= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(258649278758335); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:BN3PR07MB2643;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2643; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2643;4:PIyEfV2lq0spkbWReVY/AWSU377JDS22++uFGm/nBhy7qjlsXU4XbhEx99kGK2T31vTTHnz533SPFmLzq9vku2tLVa65u0QitMF+IM0F2fltcvaa75v5QS9iso3rBvXR8SS25BxTwCi9WhecnbbkNwrgt4rz6M4W5aBHiaU5IIudXZESKh9X/hYy0Gf7MySFy35y3JmxJN39A8Lcy+ckUWlWGAfZW8o/j9cuDMTp2tZQftfbfLxg6KIGKIoAI48zPhlsTvaNLJ8f3CnPyzCnXtMEex6eIV9eytQSWEYrbyQtZM/bzWg+TBmy+L11G4q7axapQxK6GfkvK9Hy23ClMtMJP8zJ1S/pn4TuL9zFhBGUdHFetwhJrAHf1rmT1V2P+Vsimjuxf3OsBfzeNBUjhBhsV7kZ+prOC1V7h/gJnbNyaTR8XtOfQ0cYbKbIv/3KvytOV9H7Bl7mMjxlwtZMJmrT2Z48ZF6tvb/Yd6YVqmc4B8VgGch5N/EjZ3JgSJ0AAqpTO1FOqe2fd8Xe1Ou1tPfn173YQaNYsF6KwiD1K4nkbh/164zdYGLQbEtTIGABiMMS9MfM086UqOMOUX+VZJPQF/Pbk4Yk+R+xvrgd3lsn8V7g0JEHwdGhljCVI4n7VUzvykkzqZhiKchHXlPNSA== X-Forefront-PRVS: 0204F0BDE2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(199003)(189002)(24454002)(54534003)(8676002)(106356001)(105586002)(97736004)(6916009)(81166006)(2950100002)(1076002)(46406003)(2906002)(97756001)(6666003)(1720100001)(81156014)(3846002)(23726003)(42186005)(6116002)(61506002)(92566002)(4326007)(4001350100001)(101416001)(54356999)(83506001)(110136003)(47776003)(7736002)(575784001)(50466002)(86362001)(5660300001)(305945005)(189998001)(54906002)(966004)(55016002)(6506006)(38730400001)(53936002)(25786008)(33656002)(68736007)(76176999)(50986999)(229853002)(9686003)(6306002)(66066001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2643;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR07MB2643;23:honlQslHDWCm2LpFS0yGQjdQIDCbNEbCC8V3e3djH?= =?us-ascii?Q?CVqtJK1/Kj+F4oTvatmAPzgy7ZtKyUa0EqDFLt0UJxjGQflyES8nJFNeJWyT?= =?us-ascii?Q?2mgKhlgMjYnKN9fVLk0vxhaF9CkRkKM1aT+mWobK2aAxzV6tfB2R0SzhXD1G?= =?us-ascii?Q?nIDriDLW+bbMeKQRwNl1uOCT/SCFlUh8jq88Wmblimv5l6GxIAcE8WEoX44Q?= =?us-ascii?Q?0HwZxfcJrxEzdZ6XPcYBU5U1fIXoB5tegkwdihH6Fsl6s/fJGzHtqxjMtsXf?= =?us-ascii?Q?s8syHhyyucZPcmgO/5mUbXvIa0lc901MlUov1K2hO6hI8A5Muzz0rpYueWkU?= =?us-ascii?Q?01kQllzghjXJX05VTeu1UwvJAPjGGgeIzmrOy/HRYlZzGFstyNIqRd7lJ3h7?= =?us-ascii?Q?0HIWxEEtDmI2NbfECI9iWFRKdkY6kE57uEgXIkg811BF+qkeS8WkOxSDPKzF?= =?us-ascii?Q?l4BOuRUVdRPtm3tcHRYZfDENxSJrS5U4vu9Vou7nSbKhHiPeWaA6ELhJsruR?= =?us-ascii?Q?rSaZ8qoYeB+Yw/7Ibeh6jdqIasN7q4LNIztoqadjiIAjebVYvyRUMraezK35?= =?us-ascii?Q?BmB1IDZD9kZs9DxrwK/YueLL+mqH6qSA6XmNMDNJ+jGxbK5H2y4YhipQ6SeQ?= =?us-ascii?Q?k5Hl5DYkxXNv/JtHYsT8SGReLgociD1NmCtSgwrWXAhH6hVBX9VrDxkJYAys?= =?us-ascii?Q?/iLg//x0kY0vk3LpmRWmZMgfOSNRFKZb+QhutZRouxGgP+3r7W+kKtbZqY3A?= =?us-ascii?Q?zsGDT+8rxOM9UH4tKaAtDoluPijY5FtQaUw7thXQzavSBv8rxHvGvTs7ddN0?= =?us-ascii?Q?boe3yxMw/0G+VlKoQWa+ugYIYwQkiqnUjFxQroO2BoSExzq8Kn5sN7XmQ3hh?= =?us-ascii?Q?Ag3GvLIs+srjOhcW8JhiQGJtcM2ROUUG+Zml0GHTrJSIiRskHwDDcDuixrhR?= =?us-ascii?Q?A4dxGXoXSyugxDzr58ZbYimKHdwkCT9Ahu6J9+1QCkl766lUznvwjnQMpFNw?= =?us-ascii?Q?XvXDopcYIuCMRb1X8kMmltCzw4KOHdAFoBdQpQhC7BdCxPborf01NwuF+z9u?= =?us-ascii?Q?VP15hmAlK22VjCVT51DlkB1ysrBTwIJPK9Se7g7ZboW617FBBRsQCPvErFAg?= =?us-ascii?Q?0eGz2EUJl5Hf8lTJuDdhk/X4C+jyQK9V4MYJnpSBQSvY/kO9aZGbORALaZLh?= =?us-ascii?Q?WvDCPKrXjBBIHGkqXaFQ5mm3jRodTSAJrfJu+DwPKBWGR2TMPym4aISGAU5a?= =?us-ascii?Q?/DFSoREqW2c00kn7JWW8gumYoNj7cSV6ud83DGQNTY9YehRwSm1oyADz3j7I?= =?us-ascii?Q?tstR0Gxqpi0bKXmRQZ5HE4CP4JkjLTu5GM35fmaQSrGL01M8o4rHwWElVdC0?= =?us-ascii?Q?p4BslU4nuQlNoAJJ/3bC5f71JsFu9xqgfyepdvNhk6DDl6M?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2643;6:yoA+O9Mr39m74/mDUa9cqRT61TeRUoMStH2uCCdGhfUTMDoQZzFvmtkAO1cGlPdU015OmUfmQWqBogniOTVvcSo2iKwC3vAD9i+AkronHhZ5Z2j1sbu6OiVMvh1o28AY/jexPkhKjtLAjf4ngzzwTkPFvFH5PlXFctYlpP4q+MFqaej/1ienu3YmPZEBLZm8xeVrIhOjGuOvwz4N3urPJpvzZGl76mdLhZR6Zds3Q9DumzaAjmAw6BtvASQp45tC+0GwRRKEqv8KHGuuEOnJrE7NBnMtT17JUzJMWwFPmuhZ8+t93tctkZE1/LbE3QnWNmNcxabP+3bYE1fBmKAH6vQgwNCBgHhOMy5Zvat+DPS+b3o6grnDqhAmXLVwCxemlhKVI9qbsy3zHu5N0IDDISrolfGFcPjrxYaxgF8nkdU=;5:D12p6Uhh7B6lt5GockiTKvcl3DIlLc0kBvYOBv/oRoQXnkOaDa4kvcozI13qKorPuyZEZGjuWMd2xnouBKfTaeWkifUhhqvtrH/TiVCek7hSGUlri3EkVemfYvekWIxv0VzlodREnI4w2J81uu+/GQ==;24:SlWK8gKPOIQnrhh57uzirFz6eONy1vqcMvjrvULUBbrkltQ7Gv0oovCmXEL9Qn8nB5gt+8Jv3qy5h4a12ekihbq5E7IRAOKORJ9wjIZ+g5o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2643;7:uS0BpdEef5Cz4BER9xEAfIn4ZcMIkhfmhLS0WmI9uPV2N5I8O042TvptUIyCgny2w6u2Je9XeRJwCTv615gY3238jJJLBWQ7LUxYmo5HbPHgZnrdkI4b7EhrCaQLRWe0RZFz/UFyoTqFw5U5bVmm9xOT0EH7Xgr3nRpakQIg/XjR76i6pqJB1vaje01xuPcXV2FVoghfqzK7HNcRDr73bYGKGHq5svV1YJxe3pbM7mqnlouaJi+vs0hv1ur5RZn/xndg0naw6Q5uZPHWIMBoDc+x4Bw0pQPf+4ndYTfg76mbxyrFzC8DsVi2a8DeVPuwQ3Ev3r7ffdaaLomEvXQQbZqT+PddHPlTekUb/G11+oHnNn604PUFYYv+kzK0xLtSdTx+NIcqwcuIUdfPf397GhqmrVJpgZ9qFhgM4gT5sEwqkXVdmBsQ6kw6g3yy6vLFZb4VeRuaUGZbcLE6JtjrhwRAhmbnpSlqhengIjRSWhATwwWt6CvimSjvPKUMFoRG+ZXze9EUv2xI2OUGbh+ZidFo9cXLiyTJG4C+xnMSR53V72k8LREiapO6CBk26NW0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2017 10:28:36.0971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2643 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On Mon, Jan 30, 2017 at 03:12:37PM -0600, Bjorn Helgaas wrote: > Hi Vadim, > > On Mon, Jan 30, 2017 at 08:25:52AM -0800, Vadim Lomovtsev wrote: > > This patch is to address PEM initialization issue > > which causes network issues. > > > > It is necessary to search for _HID:PNP0A08 while requesting > > PEM resources via ACPI instead of "THRX0002". > > > > Signed-off-by: Vadim Lomovtsev > > --- > > drivers/pci/host/pci-thunder-pem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/pci-thunder-pem.c b/drivers/pci/host/pci-thunder-pem.c > > index af722eb..aec30b8 100644 > > --- a/drivers/pci/host/pci-thunder-pem.c > > +++ b/drivers/pci/host/pci-thunder-pem.c > > @@ -331,7 +331,7 @@ static int thunder_pem_acpi_init(struct pci_config_window *cfg) > > if (!res_pem) > > return -ENOMEM; > > > > - ret = acpi_get_rc_resources(dev, "THRX0002", root->segment, res_pem); > > + ret = acpi_get_rc_resources(dev, "PNP0A08", root->segment, res_pem); > > This doesn't smell right: PNP0A08 is the generic ACPI ID. There's no > guarantee that if we find a PNP0A08 device, it is a ThunderX device. > > I think the only way to call thunder_pem_acpi_init() is via an MCFG > quirk that mentions thunder_pem_ecam_ops, which means we only call it > if we find an MCFG with "CAVIUM" "THUNDERX" OEM and table IDs, so it's > probably safe in that sense. Agree, it is not the best solution. We will implement such approach and send for review. > > But it's an abuse of the ACPI _HID model. If you match a device using > PNP0A08, all you can assume about it is that it uses the generic > PNP0A08 programming model, and I don't think that includes "the first > memory resource in _CRS contains ECAM space and MSI-X tables." > > I expect this is a teething issue because you have firmware in the > field that uses PNP0A08 and it's not feasible to update it. If that's > the case, the changelog should have details about it and we should > have a comment in the code, because I don't think this is the model we > want to end up with in future releases. It could become so. However, for now I didn't get any reports on that, (may be I miss something) except some internal emailings. At my testing HW I was able to see some issues related to acpi-PEM stuff. Thanks for feed-back, we will prepare another patch or patchset implementing approach you've highlighted. > > if (ret) { > > dev_err(dev, "can't get rc base address\n"); > > return ret; > > -- > > 2.4.11 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel