From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbdAaOXQ (ORCPT ); Tue, 31 Jan 2017 09:23:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:35204 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122AbdAaOW5 (ORCPT ); Tue, 31 Jan 2017 09:22:57 -0500 Date: Tue, 31 Jan 2017 15:22:49 +0100 From: Jean Delvare To: Bhumika Goyal Cc: julia.lawall@lip6.fr, ludovic.desroches@atmel.com, wsa@the-dreams.de, sonic.zhang@analog.com, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, patrice.chotard@st.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com Subject: Re: [PATCH] i2c: busses: constify i2c_algorithm structures Message-ID: <20170131152249.07265d1d@endymion> In-Reply-To: <1485540377-13686-1-git-send-email-bhumirks@gmail.com> References: <1485540377-13686-1-git-send-email-bhumirks@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Jan 2017 23:36:17 +0530, Bhumika Goyal wrote: > Declare i2c_algorithm structures as const as they are only stored in the > algo field of an i2c_adapter structure. This field is of type const, so > i2c_algorithm structures having this property can be made const too. > (...) I have vague memories that I tried to do the same long ago and it didn't work back then. But I can't no longer remember the details, and today it seems just fine to do it. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support