From: Greg KH <gregkh@linuxfoundation.org>
To: Stefan Agner <stefan@agner.ch>
Cc: balbi@kernel.org, andrzej.p@samsung.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric
Date: Wed, 1 Feb 2017 09:06:16 +0100 [thread overview]
Message-ID: <20170201080616.GA17968@kroah.com> (raw)
In-Reply-To: <20170201021917.27398-1-stefan@agner.ch>
On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote:
> Currently qw_sign requires UTF-8 character to set, but returns UTF-16
> when read. This isn't obvious when simply using cat since the null
> characters are not visible, but hexdump unveils the true string:
>
> # echo MSFT100 > os_desc/qw_sign
> # hexdump -C os_desc/qw_sign
> 00000000 4d 00 53 00 46 00 54 00 31 00 30 00 30 00 |M.S.F.T.1.0.0.|
>
> Make qw_sign symmetric by returning an UTF-8 string too. Also follow
> common convention and add a new line at the end.
Doesn't USB require that strings be in UTF-16? So why have the kernel
convert them?
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-01 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 2:19 [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner
2017-02-01 2:19 ` [PATCH 2/2] fs: configfs: use hexadecimal values and new line Stefan Agner
2017-02-01 8:07 ` Greg KH
2017-02-01 9:02 ` Felipe Balbi
2017-02-01 16:51 ` Stefan Agner
2017-02-01 8:06 ` Greg KH [this message]
2017-02-01 16:59 ` [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner
2017-02-09 18:04 ` Stefan Agner
2017-02-10 11:19 ` Greg KH
2017-02-10 12:30 ` Felipe Balbi
2017-02-10 20:29 ` Stefan Agner
2017-02-13 10:46 ` Felipe Balbi
2017-02-01 8:07 ` Greg KH
[not found] <CGME20170415013337epcas3p4871e4a671b352fed711acaf38803095f@epcas3p4.samsung.com>
2017-04-15 1:35 ` Stefan Agner
2017-04-19 8:53 ` Krzysztof Opasiak
2017-05-25 8:33 ` Stefan Agner
2017-06-02 8:25 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201080616.GA17968@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrzej.p@samsung.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox