From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbdBAIGN (ORCPT ); Wed, 1 Feb 2017 03:06:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56934 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdBAIGM (ORCPT ); Wed, 1 Feb 2017 03:06:12 -0500 Date: Wed, 1 Feb 2017 09:06:16 +0100 From: Greg KH To: Stefan Agner Cc: balbi@kernel.org, andrzej.p@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Message-ID: <20170201080616.GA17968@kroah.com> References: <20170201021917.27398-1-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201021917.27398-1-stefan@agner.ch> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: > Currently qw_sign requires UTF-8 character to set, but returns UTF-16 > when read. This isn't obvious when simply using cat since the null > characters are not visible, but hexdump unveils the true string: > > # echo MSFT100 > os_desc/qw_sign > # hexdump -C os_desc/qw_sign > 00000000 4d 00 53 00 46 00 54 00 31 00 30 00 30 00 |M.S.F.T.1.0.0.| > > Make qw_sign symmetric by returning an UTF-8 string too. Also follow > common convention and add a new line at the end. Doesn't USB require that strings be in UTF-16? So why have the kernel convert them? thanks, greg k-h