From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbdBAIIQ (ORCPT ); Wed, 1 Feb 2017 03:08:16 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56980 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbdBAIIN (ORCPT ); Wed, 1 Feb 2017 03:08:13 -0500 Date: Wed, 1 Feb 2017 09:08:17 +0100 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Peter Chen , Alan Stern , Ulf Hansson , Mark Brown , Sebastian Reichel , Rob Herring , Shawn Guo , "Rafael J. Wysocki" , Dmitry Eremin-Solenikov , Heiko Stuebner , "linux-arm-kernel@lists.infradead.org" , p.zabel@pengutronix.de, "devicetree@vger.kernel.org" , Pawel Moll , Mark Rutland , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" , Arnd Bergmann , Sascha Hauer , mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com, Fabio Estevam , oscar@naiandei.net, Stephen Boyd , Linux PM , Joshua Clayton , Linux Kernel Mailing List , mka@chromium.org, Vaibhav Hiremath , Gary Bisson , hverkuil@xs4all.nl, Krzysztof Kozlowski Subject: Re: [PATCH 2/8] power: add power sequence library Message-ID: <20170201080817.GD17968@kroah.com> References: <1483425211-14473-1-git-send-email-peter.chen@nxp.com> <1483425211-14473-3-git-send-email-peter.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 12:10:17AM +0100, Rafael J. Wysocki wrote: > On Tue, Jan 3, 2017 at 7:33 AM, Peter Chen wrote: > > We have an well-known problem that the device needs to do some power > > sequence before it can be recognized by related host, the typical > > example like hard-wired mmc devices and usb devices. > > > > This power sequence is hard to be described at device tree and handled by > > related host driver, so we have created a common power sequence > > library to cover this requirement. The core code has supplied > > some common helpers for host driver, and individual power sequence > > libraries handle kinds of power sequence for devices. The pwrseq > > librares always need to allocate extra instance for compatible > > string match. > > > > pwrseq_generic is intended for general purpose of power sequence, which > > handles gpios and clocks currently, and can cover other controls in > > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off > > if only one power sequence is needed, else call of_pwrseq_on_list > > /of_pwrseq_off_list instead (eg, USB hub driver). > > > > For new power sequence library, it can add its compatible string > > to pwrseq_of_match_table, then the pwrseq core will match it with > > DT's, and choose this library at runtime. > > > > Signed-off-by: Peter Chen > > Tested-by: Maciej S. Szmigiero > > Tested-by Joshua Clayton > > Reviewed-by: Matthias Kaehlcke > > Tested-by: Matthias Kaehlcke > > Quite honestly, I have a really hard time with trying to follow this > code and the total lack of documentation makes it even harder. In > particular, the generic power sequence code is not even commented at > all, so it really is hard to say how this is going to work, let alone > deciding whether or not to apply it. > > Plus, of course, the USB core changes must be acked by the maintainer > thereof for me to be able to handle the series. Ah crap, I wanted you to explain it as I too couldn't figure it out :) > But at this point I basically need you to explain the design to me, please. Same here. thanks, greg k-h