From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751912AbdBAITK (ORCPT ); Wed, 1 Feb 2017 03:19:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbdBAITH (ORCPT ); Wed, 1 Feb 2017 03:19:07 -0500 Date: Wed, 1 Feb 2017 09:18:52 +0100 From: Benjamin Tissoires To: Daniel Drake Cc: Chris Chiu , Jiri Kosina , Linux Kernel , linux-input@vger.kernel.org, Linux Upstreaming Team Subject: Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop Message-ID: <20170201081852.GA31658@mail.corp.redhat.com> References: <1481546578-40703-1-git-send-email-chiu@endlessm.com> <20161213081632.GC13907@mail.corp.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 01 Feb 2017 08:18:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jan 31 2017 or thereabouts, Daniel Drake wrote: > Hi Benjamin, > > On Tue, Dec 13, 2016 at 2:16 AM, Benjamin Tissoires > wrote: > > On Dec 12 2016 or thereabouts, Chris Chiu wrote: > >> ROG means ASUS "Republic of Gamers" laptops. The input device info > >> also represents itself as "ASASTeK COMPUTER INC. ROG MacroKey". It > >> uses special HID_USAGE code for function keys. This commit remap the > >> special code to standard keycode for function keys handling. It's > >> verified on GL553VD/VE, GL753VD/VE. > >> > >> Signed-off-by: Chris Chiu > >> Reported-by: Yukai Li > >> --- > > > > Hi Chris, > > > > there is no real point of having a separate driver from hid-asus. The > > HID tree prefer to group drivers by vendors, so these keyboards should > > be supported through hid-asus. > > Thanks for the feedback. We will submit a new version soon. > > Just to confirm, hid-asus currently depends on I2C_HID. The new > devices being quirked now are USB devices. With this patch should we > now update it to depend on I2C_HID && USB_HID? > Actually you can remove the I2C_HID dependency entirely (and not add one for USB_HID). In the Kconfig, the modules are already guarded by a "if HID", and there is nothing transport specific in hid-asus as far as I can tell. Note: we should also probably clean up the Kconfig once again and remove all the "depends on HID" for those that are guarded by the if statement. Cheers, Benjamin