From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: <julia.lawall@lip6.fr>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure
Date: Wed, 1 Feb 2017 15:08:26 +0000 [thread overview]
Message-ID: <20170201150826.GR1754@localhost.localdomain> (raw)
In-Reply-To: <1485610721-29264-1-git-send-email-bhumirks@gmail.com>
On Sat, Jan 28, 2017 at 07:08:41PM +0530, Bhumika Goyal wrote:
> Declare regulator_ops structure as const as it is only stored in the ops
> field of a regulator_desc structure. This field is of type const, so
> regulator_ops structures having this property can be made const too.
>
> File size before: drivers/regulator/arizona-ldo1.o
> text data bss dec hex filename
> 1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o
>
> File size after: drivers/regulator/arizona-ldo1.o
> text data bss dec hex filename
> 2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Patch looks fine but CCing patches@opensource.wolfsonmicro.com on
patches to the Arizona driver would be greatly appreciated.
Thanks,
Charles
prev parent reply other threads:[~2017-02-01 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 13:38 [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Bhumika Goyal
2017-01-31 21:19 ` Applied "regulator: arizona-ldo1: constify regulator_ops structure" to the regulator tree Mark Brown
2017-02-01 15:08 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201150826.GR1754@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=bhumirks@gmail.com \
--cc=broonie@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox