From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbdBAPIO (ORCPT ); Wed, 1 Feb 2017 10:08:14 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:49155 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752202AbdBAPIM (ORCPT ); Wed, 1 Feb 2017 10:08:12 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Wed, 1 Feb 2017 15:08:26 +0000 From: Charles Keepax To: Bhumika Goyal CC: , , , Subject: Re: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Message-ID: <20170201150826.GR1754@localhost.localdomain> References: <1485610721-29264-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1485610721-29264-1-git-send-email-bhumirks@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702010150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 28, 2017 at 07:08:41PM +0530, Bhumika Goyal wrote: > Declare regulator_ops structure as const as it is only stored in the ops > field of a regulator_desc structure. This field is of type const, so > regulator_ops structures having this property can be made const too. > > File size before: drivers/regulator/arizona-ldo1.o > text data bss dec hex filename > 1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o > > File size after: drivers/regulator/arizona-ldo1.o > text data bss dec hex filename > 2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o > > Signed-off-by: Bhumika Goyal > --- Patch looks fine but CCing patches@opensource.wolfsonmicro.com on patches to the Arizona driver would be greatly appreciated. Thanks, Charles