From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753467AbdBARCT (ORCPT ); Wed, 1 Feb 2017 12:02:19 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:54404 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbdBARBt (ORCPT ); Wed, 1 Feb 2017 12:01:49 -0500 From: Arnd Bergmann To: Tejun Heo Cc: Arnd Bergmann , Lai Jiangshan , Sebastian Andrzej Siewior , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH] workqueue: avoid clang warning Date: Wed, 1 Feb 2017 18:01:17 +0100 Message-Id: <20170201170135.2654291-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:WO3CuUnoBod3ZiMFXNCgFIzA3kH3wTLMGDpSwoac+6wrV9RsahP HD2dEfD21vLLqSIs9GWcV/nk41UFtCpZUCcnjL7xqbAMFXbto67MAQDQYANMuY0k4UezzuS UmX/VFUZlUBBkSIr8An7I21Ai7+yVWlX51E8Hhw+68SK0UWeC1eYaBV3o0p4nqV4jx2vUWZ 57moJHwsd2ZXq3MQWx4nA== X-UI-Out-Filterresults: notjunk:1;V01:K0:vc0bffbRhnA=:Ei/hxn2j+zyfPGto0xSGbE 4jR7Z+9I9b0smrcXGmyw3GvpJ3F2ofYZoGeGKq93smCwO1EaekhBQS4UJ0Xl4nNxcH84E+cj/ eHTe2tORvyaWGI/UgDzpxf+B/5beHrEJO+L6luyvehqRu/cW1fRZRJ+YCtN2/DYzA9QQC8xZD oInItrYk7qwcxXVmGQ//feMd3ZNUfWG7mayIL/Hx/N5zFej204dMnGPDyukn91CzYiUD/WNQF FdYV9t9nSdT+vIF2EvfeC5L9EYyc3R52AhI+VtZjHXNMbpf8QTvz1Swq8QMgWyDJ5JbcXCUO6 f4cdf92CeeW5dTn9Ig0raO+87J9T/WqupHbCm5yQ/+n88Ru1Nj75Tg6lmzF0Su0Yq75CeSto6 sWgfHYH1x+ReXADxZ3eS/wUtA8yJ6JLmDMXW5cspvZ0TN3jn4jW5sRONBpuV0gu3MMzHjRJeX 8NwZ6JMQ8OibtHEF0yqUCPnhnaa+awOwJlQL5O/n7aSC3DyuQUkQz8iS9S6mJXFCkwf/stE2t GFjWlVtu+/x91qIfSxgVxeh2ttV5RZeFwOVvmhi8A++00bM7sT815pka/d3628pzRa/sMlEyL L/Hy2oHif8iDBmDR9GK5avC4nR8GrImmImfB/i1o5QAm7Sq8ZwP+vyxV6XpIA8aloZOuVKEFZ fq+VL8EbRP1Q91DCzqCS+lv5mpaCuBVkVWN/T9fbWhqUsSdAULPAHBwTd80K9v16U/do= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building with clang shows lots of warning like: drivers/amba/bus.c:447:8: warning: implicit conversion from 'long long' to 'int' changes value from 4294967248 to -48 [-Wconstant-conversion] static DECLARE_DELAYED_WORK(deferred_retry_work, amba_deferred_retry_func); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/workqueue.h:187:26: note: expanded from macro 'DECLARE_DELAYED_WORK' struct delayed_work n = __DELAYED_WORK_INITIALIZER(n, f, 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/workqueue.h:177:10: note: expanded from macro '__DELAYED_WORK_INITIALIZER' .work = __WORK_INITIALIZER((n).work, (f)), \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/workqueue.h:170:10: note: expanded from macro '__WORK_INITIALIZER' .data = WORK_DATA_STATIC_INIT(), \ ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/workqueue.h:111:39: note: expanded from macro 'WORK_DATA_STATIC_INIT' ATOMIC_LONG_INIT(WORK_STRUCT_NO_POOL | WORK_STRUCT_STATIC) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ include/asm-generic/atomic-long.h:32:41: note: expanded from macro 'ATOMIC_LONG_INIT' #define ATOMIC_LONG_INIT(i) ATOMIC_INIT(i) ~~~~~~~~~~~~^~ arch/arm/include/asm/atomic.h:21:27: note: expanded from macro 'ATOMIC_INIT' #define ATOMIC_INIT(i) { (i) } ~ ^ This makes the type cast explicit, which shuts up the warning. Signed-off-by: Arnd Bergmann --- include/linux/workqueue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index a26cc437293c..bde063cefd04 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h @@ -106,9 +106,9 @@ struct work_struct { #endif }; -#define WORK_DATA_INIT() ATOMIC_LONG_INIT(WORK_STRUCT_NO_POOL) +#define WORK_DATA_INIT() ATOMIC_LONG_INIT((unsigned long)WORK_STRUCT_NO_POOL) #define WORK_DATA_STATIC_INIT() \ - ATOMIC_LONG_INIT(WORK_STRUCT_NO_POOL | WORK_STRUCT_STATIC) + ATOMIC_LONG_INIT((unsigned long)(WORK_STRUCT_NO_POOL | WORK_STRUCT_STATIC)) struct delayed_work { struct work_struct work; -- 2.9.0