From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754249AbdBASbL (ORCPT ); Wed, 1 Feb 2017 13:31:11 -0500 Received: from mga06.intel.com ([134.134.136.31]:28366 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbdBASbI (ORCPT ); Wed, 1 Feb 2017 13:31:08 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="815934848" Date: Wed, 1 Feb 2017 20:30:58 +0200 From: Jarkko Sakkinen To: tpmdd-devel@lists.sourceforge.net Cc: linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: [PATCH] tpm: fix type issues in tpm_getcap() Message-ID: <20170201183058.ubnf7wfctlryqy6v@intel.com> References: <20170201175347.2035-1-jarkko.sakkinen@linux.intel.com> <20170201181845.bsy3pfdmryqm4zgb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201181845.bsy3pfdmryqm4zgb@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 08:18:45PM +0200, Jarkko Sakkinen wrote: > On Wed, Feb 01, 2017 at 07:53:47PM +0200, Jarkko Sakkinen wrote: > > There are two type issues associated with tpm_getcap(). > > > > You must not do arithmetic with __be32 or __le32 types because sometimes > > it results incorrect results. Calculations must be done only with data > > that is in CPU byte order. This commit migrates tpm_getcap() to struct > > tpm_buf in order to sort out these issues. > > > > The second issue is with struct cap_t as the size of the type bool is > > assumed to be one byte. This commit sorts out the issue by changing the > > type to u8. > > > > Signed-off-by: Jarkko Sakkinen > > This is the only mandatory fix for the next pull request and 4.11. I mean from the reported sparse errors. /Jarkko