From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750891AbdBBDvY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Feb 2017 22:51:24 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49777 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750726AbdBBDvW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Feb 2017 22:51:22 -0500
X-ME-Sender: <xms:uaySWLprUvfUsifJsJD86yh72UL-rgqd1PcGmlI4QqGWovZ68ImNxw>
X-Sasl-enc: VC6kVj6imJVIPbMTIx3xZ/IXQBK6gbnmxduLBxm40fIx 1486007481
Date: Thu, 2 Feb 2017 14:51:17 +1100
From: Tobin Harding <me@tobin.cc>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Jan Kara <jack@suse.cz>, Ross Zwisler <ross.zwisler@linux.intel.com>,
        Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 2/4] mm: Fix checkpatch warnings, whitespace
Message-ID: <20170202035117.GA15650@eros>
References: <1485992240-10986-1-git-send-email-me@tobin.cc>
 <1485992240-10986-3-git-send-email-me@tobin.cc>
 <alpine.DEB.2.10.1702011648160.58909@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1702011648160.58909@chino.kir.corp.google.com>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 01, 2017 at 04:48:28PM -0800, David Rientjes wrote:
> On Thu, 2 Feb 2017, Tobin C. Harding wrote:
> 
> > @@ -3696,8 +3695,8 @@ int handle_mm_fault(struct vm_area_struct *vma, unsigned long address,
> >                   * VM_FAULT_OOM), there is no need to kill anything.
> >                   * Just clean up the OOM state peacefully.
> >                   */
> > -                if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
> > -                        mem_cgroup_oom_synchronize(false);
> > +		if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
> > +			mem_cgroup_oom_synchronize(false);
> >  	}
> >  
> >  	/*
> 
> The comment suffers from the same problem.

The comment is fixed in the next patch of the set. The fixes are in
separate patches because one was a checkpatch warning and one was an
error.

Any comments on the structure of the patchset most appreciated.


thanks,
Tobin.