From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Jun Nie <jun.nie@linaro.org>, Baoyou Xie <baoyou.xie@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH] reset: make zx2967 explicitly non-modular
Date: Thu, 2 Feb 2017 09:52:12 -0500 [thread overview]
Message-ID: <20170202145212.18609-1-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <CA+DQWkxP4KJbJgVtSRMez0rfzgfxhZBKvzoBvVyRVR7DhyZOjQ@mail.gmail.com>
The Kconfig currently controlling compilation of this code is:
config RESET_ZX2967
bool "ZTE ZX2967 Reset Driver
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.
Since builtin_platform_driver() was already in use, the init ordering
remains unchanged with this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
We don't replace module.h with init.h since the file does not appear
to use __init prefix anywhere.
Cc: Jun Nie <jun.nie@linaro.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/reset/reset-zx2967.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/reset/reset-zx2967.c b/drivers/reset/reset-zx2967.c
index 5d821513aa3e..4dabb9ec4841 100644
--- a/drivers/reset/reset-zx2967.c
+++ b/drivers/reset/reset-zx2967.c
@@ -8,7 +8,6 @@
* License terms: GNU General Public License (GPL) version 2
*/
-#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/platform_device.h>
#include <linux/reset-controller.h>
@@ -89,7 +88,6 @@ static const struct of_device_id zx2967_reset_dt_ids[] = {
{ .compatible = "zte,zx296718-reset", },
{},
};
-MODULE_DEVICE_TABLE(of, zx2967_reset_dt_ids);
static struct platform_driver zx2967_reset_driver = {
.probe = zx2967_reset_probe,
@@ -98,9 +96,4 @@ static struct platform_driver zx2967_reset_driver = {
.of_match_table = zx2967_reset_dt_ids,
},
};
-
builtin_platform_driver(zx2967_reset_driver);
-
-MODULE_AUTHOR("Baoyou Xie <baoyou.xie@linaro.org>");
-MODULE_DESCRIPTION("ZTE zx2967 Reset Controller Driver");
-MODULE_LICENSE("GPL");
--
2.11.0
next parent reply other threads:[~2017-02-02 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+DQWkxP4KJbJgVtSRMez0rfzgfxhZBKvzoBvVyRVR7DhyZOjQ@mail.gmail.com>
2017-02-02 14:52 ` Paul Gortmaker [this message]
2017-02-02 15:35 ` [PATCH] reset: make zx2967 explicitly non-modular Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202145212.18609-1-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=baoyou.xie@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox