From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751946AbdBBPWX (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Feb 2017 10:22:23 -0500
Received: from mail-out.m-online.net ([212.18.0.9]:36329 "EHLO
        mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751107AbdBBPWU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Feb 2017 10:22:20 -0500
X-Auth-Info: FfZCqcC63f/kX7JGN024CBCaGEB47oX7IT+yPy7S3J0=
Date: Thu, 2 Feb 2017 16:22:12 +0100
From: Lukasz Majewski <lukma@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        "David S. Miller" <davem@davemloft.net>,
        Karicheri Muralidharan <m-karicheri2@ti.com>,
        linux-kernel@vger.kernel.org, Eric Engestrom <eric@engestrom.ch>,
        netdev@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] net: phy: dp83867: Port mirroring support in the
 DP83867 TI's PHY driver
Message-ID: <20170202162212.4d479fa5@jawa>
In-Reply-To: <20170202131112.GI4967@lunn.ch>
References: <1485960215-5148-1-git-send-email-lukma@denx.de>
        <20170201171610.GC7395@lunn.ch>
        <2f3766f0-42df-6aab-dda1-14022c57fb30@gmail.com>
        <20170201220500.29d478aa@jawa>
        <20170201211440.GG7395@lunn.ch>
        <20170201231323.732dd327@jawa>
        <20170202015416.GG4967@lunn.ch>
        <20170202101739.67e7e6b3@jawa>
        <20170202131112.GI4967@lunn.ch>
Organization: denx.de
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2 Feb 2017 14:11:12 +0100
Andrew Lunn <andrew@lunn.ch> wrote:

> > The bootstrapping process in the PHY sets this bit. This is wrong
> > since the board lane layout is not "swapped"
>  
> Ah, you mean a strapping pin? Resistor to ground/VCC?

Yes, exactly.

> That is a different matter. It makes it a lot less likely to break
> some existing board with such a change.
> 
> > I have thought a bit about that and I think that we should define
> > complementary "net-phy-lane-no-swap" as suggested by Florian. Then
> > affected boards could define it and use.
> 
> This is the most flexible solution. Yes, that is O.K. for me.

Ok. thanks.

> 
>      Andrew




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de