From: "Theodore Ts'o" <tytso@mit.edu>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: adilger@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ext4: move halfmd4 into hash.c directly
Date: Thu, 2 Feb 2017 11:54:09 -0500 [thread overview]
Message-ID: <20170202165409.nwzvgdev2veh36hj@thunk.org> (raw)
In-Reply-To: <20170110000701.19472-1-Jason@zx2c4.com>
On Tue, Jan 10, 2017 at 01:07:01AM +0100, Jason A. Donenfeld wrote:
> The "half md4" transform should not be used by any new code. And
> fortunately, it's only used now by ext4. Since ext4 supports several
> hashing methods, at some point it might be desirable to move to
> something like SipHash. As an intermediate step, remove half md4 from
> cryptohash.h and lib, and make it just a local function in ext4's
> hash.c. There's precedent for doing this; the other function ext can use
> for its hashes -- TEA -- is also implemented in the same place. Also, by
> being a local function, this might allow gcc to perform some additional
> optimizations.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> Cc: Theodore Ts'o <tytso@mit.edu>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2017-02-02 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 0:07 [PATCH v2] ext4: move halfmd4 into hash.c directly Jason A. Donenfeld
2017-02-02 16:54 ` Theodore Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-22 19:19 [PATCH] " kbuild test robot
2016-12-22 19:24 ` [PATCH v2] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202165409.nwzvgdev2veh36hj@thunk.org \
--to=tytso@mit.edu \
--cc=Jason@zx2c4.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox