From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbdBBQyO (ORCPT ); Thu, 2 Feb 2017 11:54:14 -0500 Received: from imap.thunk.org ([74.207.234.97]:47142 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbdBBQyN (ORCPT ); Thu, 2 Feb 2017 11:54:13 -0500 Date: Thu, 2 Feb 2017 11:54:09 -0500 From: "Theodore Ts'o" To: "Jason A. Donenfeld" Cc: adilger@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ext4: move halfmd4 into hash.c directly Message-ID: <20170202165409.nwzvgdev2veh36hj@thunk.org> Mail-Followup-To: Theodore Ts'o , "Jason A. Donenfeld" , adilger@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170110000701.19472-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110000701.19472-1-Jason@zx2c4.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2017 at 01:07:01AM +0100, Jason A. Donenfeld wrote: > The "half md4" transform should not be used by any new code. And > fortunately, it's only used now by ext4. Since ext4 supports several > hashing methods, at some point it might be desirable to move to > something like SipHash. As an intermediate step, remove half md4 from > cryptohash.h and lib, and make it just a local function in ext4's > hash.c. There's precedent for doing this; the other function ext can use > for its hashes -- TEA -- is also implemented in the same place. Also, by > being a local function, this might allow gcc to perform some additional > optimizations. > > Signed-off-by: Jason A. Donenfeld > Reviewed-by: Andreas Dilger > Cc: Theodore Ts'o Thanks, applied. - Ted