From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752331AbdBCDNN (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Feb 2017 22:13:13 -0500
Received: from smtprelay0216.hostedemail.com ([216.40.44.216]:36624 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752271AbdBCDNM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Feb 2017 22:13:12 -0500
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3308:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:5007:6119:6261:6742:7514:7875:10004:10400:10848:10967:11232:11658:11914:12043:12663:12740:12760:12895:13069:13311:13357:13439:13618:14096:14097:14181:14659:14721:14777:21080:21212:21433:30022:30054:30056:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:28,LUA_SUMMARY:none
X-HE-Tag: rule46_55c8055677b08
X-Filterd-Recvd-Size: 2376
Date: Thu, 2 Feb 2017 22:13:06 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
        Calvin Owens <calvinowens@fb.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi
 contexts
Message-ID: <20170202221155.04b45266@grimm.local.home>
In-Reply-To: <20170203015757.GB6228@jagdpanzerIV.localdomain>
References: <20161227141611.940-1-sergey.senozhatsky@gmail.com>
        <20161227141611.940-6-sergey.senozhatsky@gmail.com>
        <20170201113700.5b464143@gandalf.local.home>
        <20170202020257.GB1954@jagdpanzerIV.localdomain>
        <20170202093409.3d7f617e@gandalf.local.home>
        <20170203015757.GB6228@jagdpanzerIV.localdomain>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 3 Feb 2017 10:57:57 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
ell. sure, no objections, but in this particular case it's hardly
possible
> to hit all of those problems within a reasonable time. so what I did was just
> a bunch of dirty hacks to provoke the problems. something like this
> 
> 	extern int XXX;
> 
> 	vprintk_emit()
> 	{
> 		spin_lock(&logbuf_lock);
> 
> 			//
> 			// in various places
> 			//
> 			if (XXX == 1) {
> 				WARN_ON(1);
> 			}
> 
> 		spin_unlock(&logbuf_lock);
> 	}
> 
> and I set/clear that XXX from one of sysfs attrs... yeah, I know...
> but it does what I want. so I'm not really sure I want to note this
> in the change log. am I wrong?

No you are not. But just seeing this in email does help. And yeah, this
is the type of testing that I do as well on things like this. No need
to put it in the change log.

-- Steve