From: Ingo Molnar <mingo@kernel.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/4] selftests, x86, protection_keys: fix unused variable compile warnings
Date: Fri, 3 Feb 2017 07:43:27 +0100 [thread overview]
Message-ID: <20170203064327.GA23708@gmail.com> (raw)
In-Reply-To: <cae9105b-b0e0-ea4a-6e5c-739af1690674@osg.samsung.com>
* Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 02/02/2017 04:45 PM, Dave Hansen wrote:
> > On 02/02/2017 03:36 PM, Shuah Khan wrote:
> >> This patches is already in linux-kselftest next for 4.11
> >>
> >> Is there a reason why you chose to resend these.
> >
> > Oh, my apologies! I didn't realize it had been picked up elsewhere.
> > Ingo had mentioned a few times in the last few days that he'd noticed
> > the warnings.
> >
> > So, x86 maintainers, do we want these to go through the kselftest tree
> > or the x86 tree?
> >
>
> I usually let many of the new tests that depend on new features go through
> x86 tree. Patches that fix problems that are already in kselftest, I send
> them up in via kselftest.
>
> I noticed these when very early on when 4.10-rc1 came out and send the patches
> out. SO they have been in linux-kselftest next for a while now.
That's OK, but please Cc: me (or at least lkml) next time around.
Also, these should have been sent to Linus as fixes once the warnings were
noticed, not queued up for v4.11 - but it's probably too late for that.
Are you going to pick up the other two fixes as well? They look good to me:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2017-02-03 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 23:28 [PATCH 0/4] selftests, x86: updates for x86 protection keys self tests Dave Hansen
2017-02-02 23:28 ` [PATCH 1/4] selftests, x86, protection_keys: fix unused variable compile warnings Dave Hansen
2017-02-02 23:36 ` Shuah Khan
2017-02-02 23:45 ` Dave Hansen
2017-02-02 23:49 ` Shuah Khan
2017-02-03 6:43 ` Ingo Molnar [this message]
2017-02-02 23:28 ` [PATCH 2/4] selftests, x86, protection_keys: remove dead code Dave Hansen
2017-02-02 23:36 ` Shuah Khan
2017-02-02 23:28 ` [PATCH 3/4] selftests, x86, protection_keys: fix uninitialized variable warning Dave Hansen
2017-02-02 23:28 ` [PATCH 4/4] selftests, x86, protection_keys: fix wrong offset in siginfo Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203064327.GA23708@gmail.com \
--to=mingo@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox