From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdBCGnd (ORCPT ); Fri, 3 Feb 2017 01:43:33 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33232 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbdBCGnb (ORCPT ); Fri, 3 Feb 2017 01:43:31 -0500 Date: Fri, 3 Feb 2017 07:43:27 +0100 From: Ingo Molnar To: Shuah Khan Cc: Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/4] selftests, x86, protection_keys: fix unused variable compile warnings Message-ID: <20170203064327.GA23708@gmail.com> References: <20170202232842.C3C30DB2@viggo.jf.intel.com> <20170202232844.BFD31FAD@viggo.jf.intel.com> <0262a979-6051-7007-f119-f45ede9449b7@osg.samsung.com> <9c1b1172-ade9-b8c3-c7dc-5dc818504622@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Shuah Khan wrote: > On 02/02/2017 04:45 PM, Dave Hansen wrote: > > On 02/02/2017 03:36 PM, Shuah Khan wrote: > >> This patches is already in linux-kselftest next for 4.11 > >> > >> Is there a reason why you chose to resend these. > > > > Oh, my apologies! I didn't realize it had been picked up elsewhere. > > Ingo had mentioned a few times in the last few days that he'd noticed > > the warnings. > > > > So, x86 maintainers, do we want these to go through the kselftest tree > > or the x86 tree? > > > > I usually let many of the new tests that depend on new features go through > x86 tree. Patches that fix problems that are already in kselftest, I send > them up in via kselftest. > > I noticed these when very early on when 4.10-rc1 came out and send the patches > out. SO they have been in linux-kselftest next for a while now. That's OK, but please Cc: me (or at least lkml) next time around. Also, these should have been sent to Linus as fixes once the warnings were noticed, not queued up for v4.11 - but it's probably too late for that. Are you going to pick up the other two fixes as well? They look good to me: Acked-by: Ingo Molnar Thanks, Ingo