Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues

Christoph Hellwig
2017-02-03T09:52:23Z

On Fri, Feb 03, 2017 at 05:47:41PM +0800, Jason Wang wrote:
>> No, we need to allocate the array larger in that case as want proper
>> names for the interrupts.
>
> Consider the case of !per_vq_vectors, the size of msix_names is 2, but
> snprintf can do out of bound accessing here. (We name the msix shared by
> virtqueues with something like "%s-virtqueues" before the patch).

Yes, that's what I meant above - we need to allocate a large array
starting with this patch. I'll fix it up for the next version.