From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753015AbdBCJwX (ORCPT ); Fri, 3 Feb 2017 04:52:23 -0500 Received: from verein.lst.de ([213.95.11.211]:47010 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbdBCJwV (ORCPT ); Fri, 3 Feb 2017 04:52:21 -0500 Date: Fri, 3 Feb 2017 10:52:19 +0100 From: Christoph Hellwig To: Jason Wang Cc: Christoph Hellwig , mst@redhat.com, axboe@kernel.dk, pbonzini@redhat.com, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Message-ID: <20170203095219.GA28483@lst.de> References: <1485504997-17584-1-git-send-email-hch@lst.de> <1485504997-17584-3-git-send-email-hch@lst.de> <20170203082606.GB26800@lst.de> <12332f9d-2cf8-d761-032e-a5a89863fd09@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12332f9d-2cf8-d761-032e-a5a89863fd09@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2017 at 05:47:41PM +0800, Jason Wang wrote: >> No, we need to allocate the array larger in that case as want proper >> names for the interrupts. > > Consider the case of !per_vq_vectors, the size of msix_names is 2, but > snprintf can do out of bound accessing here. (We name the msix shared by > virtqueues with something like "%s-virtqueues" before the patch). Yes, that's what I meant above - we need to allocate a large array starting with this patch. I'll fix it up for the next version.