From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbdBCJwf (ORCPT ); Fri, 3 Feb 2017 04:52:35 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44464 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbdBCJwd (ORCPT ); Fri, 3 Feb 2017 04:52:33 -0500 Date: Fri, 3 Feb 2017 10:52:36 +0100 From: Greg Kroah-Hartman To: Zhengyi Shen Cc: Walt Feasel , Afonso Bordado , Bhumika Goyal , Arnd Bergmann , Anjali Menon , Dilek Uzulmez , Gargi Sharma , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/emxx_udc: Fix styling issues Message-ID: <20170203095236.GB24767@kroah.com> References: <20170202125654.32378-1-shenzhengyi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170202125654.32378-1-shenzhengyi@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2017 at 08:56:54PM +0800, Zhengyi Shen wrote: > Fix line over 80 characters. > Statements longer than 80 columns were broken into sensible chunks. > Descendants in four different palces were in the same uniform style. > > Signed-off-by: Zhengyi Shen > --- > drivers/staging/emxx_udc/emxx_udc.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 77b242e..e771aee 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -902,7 +902,8 @@ static int _nbu2ss_epn_out_pio( > /* Copy of every four bytes */ > for (i = 0; i < iWordLength; i++) { > pBuf32->dw = > - _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_READ); > + _nbu2ss_readl( > + &preg->EP_REGS[ep->epnum - 1].EP_READ); That's horrid, and not any better than the original code :( > pBuf32++; > } > result = iWordLength * sizeof(u32); > @@ -912,7 +913,8 @@ static int _nbu2ss_epn_out_pio( > if (data > 0) { > /*---------------------------------------------------------*/ > /* Copy of fraction byte */ > - Temp32.dw = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_READ); > + Temp32.dw = > + _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_READ); Same here, please leave the original as-is. > for (i = 0 ; i < data ; i++) > pBuf32->byte.DATA[i] = Temp32.byte.DATA[i]; > result += data; > @@ -977,8 +979,8 @@ static int _nbu2ss_epn_out_transfer( > > /*-------------------------------------------------------------*/ > /* Receive Length */ > - iRecvLength > - = _nbu2ss_readl(&preg->EP_REGS[num].EP_LEN_DCNT) & EPn_LDATA; > + iRecvLength = > + _nbu2ss_readl(&preg->EP_REGS[num].EP_LEN_DCNT) & EPn_LDATA; > > if (iRecvLength != 0) { > result = _nbu2ss_epn_out_data(udc, ep, req, iRecvLength); > @@ -2651,7 +2653,8 @@ static int nbu2ss_ep_queue( > } > > req = container_of(_req, struct nbu2ss_req, req); > - if (unlikely(!_req->complete || !_req->buf || !list_empty(&req->queue))) { > + if (unlikely(!_req->complete || !_req->buf > + || !list_empty(&req->queue))) { odd indentation :(